This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Move rest/admin to use async/await. #6196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
Oct 11, 2019
|
|
||
|
|
||
| @defer.inlineCallbacks | ||
| def assert_user_is_admin(auth, user_id): | ||
| async def assert_user_is_admin(auth, user_id): | ||
| """Verify that the given user is an admin user | ||
|
|
||
| WARNING: MAKE SURE YOU YIELD ON THE RESULT! |
hawkowl
reviewed
Oct 14, 2019
|
|
||
|
|
||
| @attr.s(slots=True, frozen=True) | ||
| class DoneAwaitable(object): |
There was a problem hiding this comment.
can you not use twisted.internet.defer.succeed?
There was a problem hiding this comment.
Oh, hmm, true. Though given I've written it now and this is (presumably?) pretty fast I think I might leave it for now.
3 tasks
48 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #6195