Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add some benchmarks for LruCache #6446

Merged
merged 20 commits into from
Apr 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/6446.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add benchmarks for LruCache.
16 changes: 13 additions & 3 deletions synmark/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,15 @@
# limitations under the License.

import sys
from argparse import REMAINDER
from contextlib import redirect_stderr
from io import StringIO

import pyperf
from synmark import make_reactor
from synmark.suites import SUITES

from twisted.internet.defer import ensureDeferred
from twisted.internet.defer import Deferred, ensureDeferred
from twisted.logger import globalLogBeginner, textFileLogObserver
from twisted.python.failure import Failure

Expand All @@ -40,7 +41,8 @@ def _main(loops):
file_out = StringIO()
with redirect_stderr(file_out):

d = ensureDeferred(main(reactor, loops))
d = Deferred()
d.addCallback(lambda _: ensureDeferred(main(reactor, loops)))

def on_done(_):
if isinstance(_, Failure):
Expand All @@ -50,6 +52,7 @@ def on_done(_):
return _

d.addBoth(on_done)
reactor.callWhenRunning(lambda: d.callback(True))
reactor.run()

return d.result
Expand All @@ -62,11 +65,13 @@ def on_done(_):
def add_cmdline_args(cmd, args):
if args.log:
cmd.extend(["--log"])
cmd.extend(args.tests)

runner = pyperf.Runner(
processes=3, min_time=2, show_name=True, add_cmdline_args=add_cmdline_args
processes=3, min_time=1.5, show_name=True, add_cmdline_args=add_cmdline_args
)
runner.argparser.add_argument("--log", action="store_true")
runner.argparser.add_argument("tests", nargs=REMAINDER)
runner.parse_args()

orig_loops = runner.args.loops
Expand All @@ -79,6 +84,11 @@ def add_cmdline_args(cmd, args):
)
setupdb()

if runner.args.tests:
SUITES = list(
filter(lambda x: x[0].__name__.split(".")[-1] in runner.args.tests, SUITES)
)

for suite, loops in SUITES:
if loops:
runner.args.loops = loops
Expand Down
10 changes: 8 additions & 2 deletions synmark/suites/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
from . import logging
from . import logging, lrucache, lrucache_evict

SUITES = [(logging, 1000), (logging, 10000), (logging, None)]
SUITES = [
(logging, 1000),
(logging, 10000),
(logging, None),
(lrucache, None),
(lrucache_evict, None),
]
34 changes: 34 additions & 0 deletions synmark/suites/lrucache.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
# -*- coding: utf-8 -*-
# Copyright 2019 The Matrix.org Foundation C.I.C.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from pyperf import perf_counter

from synapse.util.caches.lrucache import LruCache


async def main(reactor, loops):
"""
Benchmark `loops` number of insertions into LruCache without eviction.
"""
cache = LruCache(loops)

start = perf_counter()

for i in range(loops):
cache[i] = True

end = perf_counter() - start

return end
35 changes: 35 additions & 0 deletions synmark/suites/lrucache_evict.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
# -*- coding: utf-8 -*-
# Copyright 2019 The Matrix.org Foundation C.I.C.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from pyperf import perf_counter

from synapse.util.caches.lrucache import LruCache


async def main(reactor, loops):
"""
Benchmark `loops` number of insertions into LruCache where half of them are
evicted.
"""
cache = LruCache(loops // 2)

start = perf_counter()

for i in range(loops):
cache[i] = True

end = perf_counter() - start

return end