This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Port handlers.account_validity to async/await. #6504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/account_validity_async_await
branch
from
9295909
to
3f97b4c
Compare
richvdh
approved these changes
Dec 11, 2019
| @@ -54,6 +51,5 @@ def get_new_events(self, user, from_key, **kwargs): | |||
|
|
|||
| return results, current_stream_id | |||
|
|
|||
| @defer.inlineCallbacks | |||
| def get_pagination_rows(self, user, config, key): | |||
| async def get_pagination_rows(self, user, config, key): | |||
There was a problem hiding this comment.
You raise a good point, seems like only /initialSync uses it for presence and receipts. Given it's kind of part of the *EventSource API I'll leave it to another PR to remove it from everywhere.
48 tasks
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
…_await * commit '31905a518': Newsfile Port handlers.account_validity to async/await. Port handlers.account_data to async/await.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.