This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Update aliases event after deletion #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to update the appropriate `m.room.aliases` event after deleting an alias. This may fail due to the deleter not being in the room. Will also check if the canonical alias of the event is set to the deleted alias, and if so will attempt to delete it.
|
Sytest: matrix-org/sytest#216 |
|
LGTM |
| @@ -93,7 +95,7 @@ def create_appservice_association(self, service, room_alias, room_id, | |||
| yield self._create_association(room_alias, room_id, servers) | |||
|
|
|||
| @defer.inlineCallbacks | |||
| def delete_association(self, user_id, room_alias): | |||
| def delete_association(self, requester, user_id, room_alias): | |||
There was a problem hiding this comment.
Is the user_id different from the requester?
There was a problem hiding this comment.
The requester is a separate type, which includes a user. Not sure why the functions in this module ask for both. I'm not even sure why the requester is needed.
erikjohnston
added a commit
that referenced
this pull request
Mar 18, 2016
Update aliases event after deletion
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to update the appropriate
m.room.aliasesevent after deleting an alias. This may fail due to the deleter not being in the room.Will also check if the canonical alias of the event is set to the deleted alias, and if so will attempt to delete it.