Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix an error which was thrown by the PresenceHandler _on_shutdown handler. #6640

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Fix an error which was thrown by the PresenceHandler _on_shutdown handler. #6640

merged 1 commit into from
Jan 6, 2020

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jan 6, 2020

The exception looked like:

2020-01-06 10:05:01,649 - synapse.metrics.background_process_metrics - 214 - ERROR - presence.on_shutdown-0 - Background process 'presence.on_shutdown' threw an exception
Traceback (most recent call last):
  File "/venv/lib/python3.5/site-packages/synapse/metrics/background_process_metrics.py", line 212, in run
    return (yield result)
  File "/venv/lib/python3.5/site-packages/synapse/util/patch_inline_callbacks.py", line 190, in check_yield_points_inner
    result = yield d
AttributeError: 'DataStore' object has no attribute 'database'

Introduced (I think) by #6513

@richvdh richvdh requested a review from a team January 6, 2020 11:49
@richvdh richvdh merged commit ab4b4ee into develop Jan 6, 2020
@richvdh richvdh deleted the rav/fix_presence_shutdown branch January 6, 2020 14:34
babolivier pushed a commit that referenced this pull request Sep 1, 2021
@anoadragon453
Fix an error which was thrown by the PresenceHandler _on_shutdown han…
6c382fb 
…dler. (#6640)

* commit 'ab4b4ee6a':
  Fix an error which was thrown by the PresenceHandler _on_shutdown handler. (#6640)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richvdh @erikjohnston