-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Support login using Javascript Web Tokens (JWT) #671
Conversation
Can one of the admins verify this patch? |
3 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Thanks! I'll take a look tomorrow. Sorry about the matrixbot thing, its a bug in how we're using jenkins :( |
@matrixbot ok to test |
(Jenkins is now complaining about the fact that jwt isn't installed.) |
Thanks! I'll fix these things if you are ok with the rest. |
I'm using PyJWT for JWT decoding, but I can't get it work with Synapse's dependency management. |
@matrixbot ok to test |
LGTM (even jenkins is happy!) Our unit testing is a bit woeful atm; the bulk of the testing is done via sytest, which is written in Perl. Since this is a fairly simple PR I'm happy to just merge this now and for us to add a sytest for it down the line (unless you're happy writing Perl). Could you also follow https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst#sign-off, i.e. adding |
Signed-off-by: Niklas Riekenbrauck nikriek@gmail.com |
Thanks! |
Thanks! Feel free to open a PR to add yourself to the AUTHORS.rst. |
The flow is not fully tested. I'm open for comments first.