Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Support login using Javascript Web Tokens (JWT) #671

Merged
merged 1 commit into from
Mar 29, 2016
Merged

Support login using Javascript Web Tokens (JWT) #671

merged 1 commit into from
Mar 29, 2016

Conversation

nikriek
Copy link
Contributor

@nikriek nikriek commented Mar 28, 2016

The flow is not fully tested. I'm open for comments first.

@matrixbot
Copy link
Member

Can one of the admins verify this patch?

3 similar comments
@matrixbot
Copy link
Member

Can one of the admins verify this patch?

@matrixbot
Copy link
Member

Can one of the admins verify this patch?

@matrixbot
Copy link
Member

Can one of the admins verify this patch?

@nikriek nikriek changed the title Support login using JWT tokens Support login using Javascript Web Tokens (JWT) Mar 28, 2016
@erikjohnston
Copy link
Member

Thanks! I'll take a look tomorrow.

Sorry about the matrixbot thing, its a bug in how we're using jenkins :(

@erikjohnston
Copy link
Member

@matrixbot ok to test

@erikjohnston erikjohnston self-assigned this Mar 28, 2016
@erikjohnston
Copy link
Member

(Jenkins is now complaining about the fact that jwt isn't installed.)

@nikriek
Copy link
Contributor Author

nikriek commented Mar 28, 2016

Thanks! I'll fix these things if you are ok with the rest.

@nikriek
Copy link
Contributor Author

nikriek commented Mar 28, 2016

I'm using PyJWT for JWT decoding, but I can't get it work with Synapse's dependency management.

@erikjohnston
Copy link
Member

@matrixbot ok to test

@erikjohnston
Copy link
Member

@erikjohnston
Copy link
Member

LGTM (even jenkins is happy!)

Our unit testing is a bit woeful atm; the bulk of the testing is done via sytest, which is written in Perl. Since this is a fairly simple PR I'm happy to just merge this now and for us to add a sytest for it down the line (unless you're happy writing Perl).

Could you also follow https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst#sign-off, i.e. adding Signed-off-by: Your Name <your@email.example.org> to the commit or simply commenting here?

@nikriek
Copy link
Contributor Author

nikriek commented Mar 29, 2016

Signed-off-by: Niklas Riekenbrauck nikriek@gmail.com

@nikriek
Copy link
Contributor Author

nikriek commented Mar 29, 2016

Thanks!

@erikjohnston
Copy link
Member

Thanks! Feel free to open a PR to add yourself to the AUTHORS.rst.

@erikjohnston erikjohnston merged commit f5bf45a into matrix-org:develop Mar 29, 2016
@nikriek nikriek mentioned this pull request Mar 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants