This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Require user to have left room to forget room #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dramatically simplifies the forget API code - in particular it no longer generates a leave event.
This was referenced Mar 30, 2016
| user_id, room_id | ||
| )) | ||
|
|
||
| yield self.store.forget(user_id, room_id) |
There was a problem hiding this comment.
Does store.forget work if the user doesn't have a membership in the room?
|
@NegativeMjark PTAL |
|
Should forgetting fail if you aren't in the room? Otherwise LGTM |
I quite like that it doesn't, since then you can't use the API to tell if you had forgotten the room or were never in it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dramatically simplifies the forget API code - in particular it no longer generates a leave event.
matrix-org/sytest#220