This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Optional dependencies specifically for building the debs #7210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryans
reviewed
Apr 2, 2020
| @@ -100,6 +98,9 @@ | |||
| "sentry": ["sentry-sdk>=0.7.2"], | |||
| "opentracing": ["jaeger-client>=4.0.0", "opentracing>=2.2.0"], | |||
| "jwt": ["pyjwt>=1.6.4"], | |||
| # Pillow 7.1.0 causes the following issue on debian buster: | |||
There was a problem hiding this comment.
More than just buster was affected, it was just the first to report an error.
richvdh
suggested changes
Apr 2, 2020
|
to enlarge on the above, I'd like to see us doing this with patches in the In any case, I think |
|
I think #7212 is the correct solution here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only applies the workaround for #7208 to building debian packages, not regular Synapse users.
Prevents people with Pillow v7.1.0 from receiving an error trying to start Synapse. They could downgrade, but it'd be a massive faff.