Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Make it clearer to the user that they haven't overridden onLogin/Register #7237

Merged
merged 3 commits into from
Apr 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/7237.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Change log line that told user to implement onLogin/onRegister fallback js functions to a warning, instead of an info, so it's more visible.
3 changes: 1 addition & 2 deletions synapse/static/client/login/js/login.js
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,7 @@ matrixLogin.password_login = function() {

matrixLogin.onLogin = function(response) {
// clobber this function
console.log("onLogin - This function should be replaced to proceed.");
console.log(response);
console.warn("onLogin - This function should be replaced to proceed.");
};

var parseQsFromUrl = function(query) {
Expand Down
2 changes: 1 addition & 1 deletion synapse/static/client/register/js/register.js
Original file line number Diff line number Diff line change
Expand Up @@ -113,5 +113,5 @@ matrixRegistration.signUp = function() {

matrixRegistration.onRegistered = function(hs_url, user_id, access_token) {
// clobber this function
console.log("onRegistered - This function should be replaced to proceed.");
console.warn("onRegistered - This function should be replaced to proceed.");
};