This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow new users to be registered via the admin API even if the monthly active user limit has been reached #7263
Allow new users to be registered via the admin API even if the monthly active user limit has been reached #7263
Changes from 5 commits
d813e69
8f75ac6
26bddb3
b1ad0f0
4c2d3a7
ae0eff0
75975e0
b3b347b
9c17aa2
cf1c9ea
b9d9bec
d3b0a82
d47b564
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
help me out here: what is the difference between these tests and the ones further up at line 327 etc? what is the purpose of calling sync etc?
Perhaps some more comments to explain the test strategy and whwhat we're trying to do would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added more comments.
The difference is the
sync
.If admin did a sync before mau limit is reached, the admin can send
POST
requests and create new users.If admin did not a
sync
before limit is reached, the admin can not create new users, because the admin can not sendPOST
requests. The admin is limited like a normal user.