Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Improve example TURN configuration #7284

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Improve example TURN configuration #7284

merged 1 commit into from
Apr 17, 2020

Conversation

nataraj-hates-MS-for-stealing-github
Copy link
Contributor

Should use quotes for turn_shared_secret value, or it will not work

Me and my firends met same problem on this spot. When you are not familiar with software it is difficult to find why it does not work, when there are no quotes there...

@nataraj-hates-MS-for-stealing-github
Copy link
Contributor Author

No new newsfragments found on this branch.

I do not think this fix worth mentioning anywhere. Just commit it please, so people have no problems setting up the turn? please

@clokep
Copy link
Member

clokep commented Apr 16, 2020

@nataraj-hates-MS-for-stealing-github All of our pull requests require newsfiles. You can make one at changelog.d/7284.doc with a brief description of the change.

I don't think this requires quotes, by the way, unless your shared secret has some special characters in it maybe? By default YAML treats values as strings.

Additionally, please change your base branch to be develop, not master. Thanks!

@anoadragon453
Copy link
Member

A shared secret could technically have [ and ] characters in it, so adding quotes in that case would indeed be necessary. Doesn't hurt to add them I suppose.

@clokep clokep changed the title turn-howto fix Improve example TURN configuration Apr 17, 2020
@clokep
Copy link
Member

clokep commented Apr 17, 2020

All of our pull requests require newsfiles. You can make one at changelog.d/7284.doc with a brief description of the change.

Additionally, please change your base branch to be develop, not master. Thanks!

I was wrong about this, doc only changes like this are fine to merge as is. 👍

@clokep clokep merged commit 0d775fc into matrix-org:master Apr 17, 2020
phil-flex pushed a commit to phil-flex/synapse that referenced this pull request May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants