Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Don't relay REMOTE_SERVER_UP cmds to same conn. #7352

Merged
merged 4 commits into from
Apr 29, 2020
Merged

Don't relay REMOTE_SERVER_UP cmds to same conn. #7352

merged 4 commits into from
Apr 29, 2020

Commits on Apr 27, 2020

  1. Pass connection to 'on_*' replication handler

    @erikjohnston
    erikjohnston committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    7022704 View commit details
    Browse the repository at this point in the history

  2. Don't relay REMOTE_SERVER_UP cmds to same conn. 

    For direct TCP connections we need the master to relay REMOTE_SERVER_UP
commands to the other connections so that all instances get notified
about it. The old implementation just relayed to all connections,
assuming that sending back to the original sender of the command was
safe. This is not true for redis, where commands sent get echoed back to
the sender, which was causing master to effectively infinite loop
sending and then re-receiving REMOTE_SERVER_UP commands that it sent.

The fix is to ensure that we only relay to *other* connections and not
to the connection we received the notification from.

Fixes #7334.
    @erikjohnston
    erikjohnston committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    659b6be View commit details
    Browse the repository at this point in the history

  3. Newsfile

    @erikjohnston
    erikjohnston committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    929dbb0 View commit details
    Browse the repository at this point in the history

  4. Add test

    @erikjohnston
    erikjohnston committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    0877107 View commit details
    Browse the repository at this point in the history