This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commits on Sep 18, 2019
-
Add experimental "dont_push" push action to suppress push for notific…
…ations This is a potential solution to https://github.com/vector-im/riot-web/issues/3374 and element-hq/element-web#5953 as raised by Mozilla at element-hq/element-web#10868. This lets you define a push rule action which increases the badge count (unread notification) count on a given room, but doesn't actually send a push for that notification via email or HTTP. We might want to define this as the default behaviour for group chats in future to solve https://github.com/vector-im/riot-web/issues/3268 at last. This is implemented as a string action rather than a tweak because: * Other pushers don't care about the tweak, given they won't ever get pushed * The DB can store the tweak more efficiently using the existing `notify` table. * It avoids breaking the default_notif/highlight_action optimisations. Clients which generate their own notifs (e.g. desktop notifs from Riot/Web would need to be aware of the new push action) to uphold it. An alternative way to do this would be to maintain a `msg_count` alongside `highlight_count` and `notification_count` in `unread_notifications` in sync responses. However, doing this by counting the rows in `events` since the `stream_position` of the user's last read receipt turns out to be painfully slow (~200ms), perhaps due to the size of the events table. So instead, we use the highly optimised existing event_push_actions (and event_push_actions_staging) table to maintain the counts - using the code paths which already exist for tracking unread notification counts efficiently. These queries are typically ~3ms or so. The biggest issues I see here are: * We're slightly repurposing the `notif` field on `event_push_actions` to track whether a given action actually sent a `push` or not. This doesn't seem unreasonable, but it's slightly naughty given that previously the field explicitly tracked whether `notify` was true for the action (and as a result, it was uselessly always set to 1 in the DB). * We're going to put more load on the `event_push_actions` table for all the random group chats which people had previously muted. In practice i don't think there are many of these though. * There isn't an MSC for this yet (although this comment could become one).
Configuration menu - View commit details
-
Copy full SHA for 2292dc3 - Browse repository at this point
Copy the full SHA 2292dc3View commit details
Commits on Sep 19, 2019
-
Configuration menu - View commit details
-
Copy full SHA for dd8e24f - Browse repository at this point
Copy the full SHA dd8e24fView commit details
Commits on Jun 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ec0a7b9 - Browse repository at this point
Copy the full SHA ec0a7b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f6a4bf - Browse repository at this point
Copy the full SHA 6f6a4bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef345c5 - Browse repository at this point
Copy the full SHA ef345c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7b99a1 - Browse repository at this point
Copy the full SHA c7b99a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 476a897 - Browse repository at this point
Copy the full SHA 476a897View commit details -
Configuration menu - View commit details
-
Copy full SHA for aad40e3 - Browse repository at this point
Copy the full SHA aad40e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for df3323a - Browse repository at this point
Copy the full SHA df3323aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 243f0ba - Browse repository at this point
Copy the full SHA 243f0baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9dbd006 - Browse repository at this point
Copy the full SHA 9dbd006View commit details
Commits on Jun 11, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ea8f6e6 - Browse repository at this point
Copy the full SHA ea8f6e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce74a66 - Browse repository at this point
Copy the full SHA ce74a66View commit details -
Configuration menu - View commit details
-
Copy full SHA for d0f0956 - Browse repository at this point
Copy the full SHA d0f0956View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34fd1f7 - Browse repository at this point
Copy the full SHA 34fd1f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8032917 - Browse repository at this point
Copy the full SHA 8032917View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb6d4d0 - Browse repository at this point
Copy the full SHA cb6d4d0View commit details
Commits on Jun 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3cc7f43 - Browse repository at this point
Copy the full SHA 3cc7f43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a07c5d - Browse repository at this point
Copy the full SHA 2a07c5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 63d9a00 - Browse repository at this point
Copy the full SHA 63d9a00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b1fa32 - Browse repository at this point
Copy the full SHA 6b1fa32View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e80c84 - Browse repository at this point
Copy the full SHA 7e80c84View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf92fbb - Browse repository at this point
Copy the full SHA cf92fbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9549d55 - Browse repository at this point
Copy the full SHA 9549d55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e5a503 - Browse repository at this point
Copy the full SHA 1e5a503View commit details -
Configuration menu - View commit details
-
Copy full SHA for e47e5a2 - Browse repository at this point
Copy the full SHA e47e5a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e186c66 - Browse repository at this point
Copy the full SHA e186c66View commit details
Commits on Jun 15, 2020
-
Configuration menu - View commit details
-
Copy full SHA for fed493c - Browse repository at this point
Copy the full SHA fed493cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2b4621 - Browse repository at this point
Copy the full SHA c2b4621View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6efb2b0 - Browse repository at this point
Copy the full SHA 6efb2b0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.