Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Back out MSC2625 implementation #7761

Merged
merged 3 commits into from
Jul 1, 2020
Merged

Conversation

babolivier
Copy link
Contributor

Back out the MSC2625 implementation which we're going to ditch in favour of MSC2654 (#7741).

This reverts commit 46613aa, reversing
changes made to e452973.
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. We should probably drop the spurious column on matrix.org (and anywhere else we know this got deployed)

@babolivier
Copy link
Contributor Author

We should probably drop the spurious column on matrix.org (and anywhere else we know this got deployed)

We probably don't need to drop anything given iirc it was using an existing notif column (that's usually always 1).

@richvdh
Copy link
Member

richvdh commented Jun 30, 2020

well, afaict you're removing a schema delta that adds a column, ergo we must have a spare column now...

@babolivier
Copy link
Contributor Author

Oh right, sorry I didn't look at the diff and was thinking about another column. Yes we should drop this column from wherever we deployed this implementation.

@babolivier babolivier force-pushed the babolivier/revert_msc2625 branch from b5159f6 to 67bc8e5 Compare June 30, 2020 16:21
@babolivier babolivier merged commit 74d3e17 into develop Jul 1, 2020
@babolivier babolivier deleted the babolivier/revert_msc2625 branch July 1, 2020 10:08
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit 'dc80a0762':
  1.16.0rc1
  Back out MSC2625 implementation (#7761)
  Additional configuration options for auto-join rooms (#7763)
  Add some metrics for inbound and outbound federation processing times (#7755)
  Explain the purpose of the "tests" conditional dependency requirement (#7751)
  Add another yield point to state res v2 (#7746)
  Move flake8 to end. Don't exit script on failure (#7738)
  Make tox actions work on Debian 10 (#7703)
  Yield during large v2 state res. (#7735)
  add org.matrix.login.jwt so that m.login.jwt can be deprecated (#7675)
  Set Content-Length for Metrics requests (#7730)
  Sync ignored table names in synapse_port_db to current database schema (#7717)
  Allow local media to be marked as safe from being quarantined. (#7718)
  Convert directory handler to async/await (#7727)
  Speed up state res v2 across large state differences. (#7725)
@richvdh richvdh mentioned this pull request Apr 5, 2022
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants