This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Type checking for FederationHandler
#7770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix a few things to make this pass mypy.
richvdh
force-pushed
the
rav/mypy_fedhandler
branch
from
c01a8bc
to
4767c1f
Compare
clokep
reviewed
Jul 1, 2020
Comment on lines
+2839
to
+2842
| if last_exception is None: | ||
| # we can only get here if get_public_keys() returned an empty list | ||
| # TODO: make this better | ||
| raise RuntimeError("no public key in invite event") |
There was a problem hiding this comment.
Seems fine, but curious if we were actually running into it?
There was a problem hiding this comment.
I don't think so, but I had to do something here to keep mypy happy.
There was a problem hiding this comment.
in theory I suspect we could run into it if the invite was malformed.
There was a problem hiding this comment.
Makes sense! The result is similar either way, wasn't sure if you came across it in Sentry or something. 👍
clokep
approved these changes
Jul 1, 2020
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '5cdca53aa': Merge different Resource implementation classes (#7732) Fix inconsistent handling of upper and lower cases of email addresses. (#7021) Allow YAML config file to contain None (#7779) Fix a typo. Move 1.15.2 after 1.16.0rc2. 1.16.0rc2 Remove an extraneous space. Add links to the fixes. Fix tense in the release notes. Hack to add push priority to push notifications (#7765) Add early returns to `_check_for_soft_fail` (#7769) Use symbolic names for replication stream names (#7768) Type checking for `FederationHandler` (#7770) Fix new metric where we used ms instead of seconds (#7771) Fix incorrect error message when database CTYPE was set incorrectly. (#7760) Pin link in CHANGES.md Fixes to CHANGES.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a few things to make this pass mypy.