Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Convert E2E key and room key handlers to async/await #7851

Merged
merged 5 commits into from
Jul 15, 2020
Merged

Conversation

clokep
Copy link
Member

@clokep clokep commented Jul 14, 2020

These were straightforward, I added defer.ensureDeferred to the tests until those are converted from using inlineCallbacks. The diff kind of became a disaster once black got a hold of it. 😢

@clokep clokep requested a review from a team July 14, 2020 19:56
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, modulo CI fail

@clokep clokep merged commit b11450d into develop Jul 15, 2020
@clokep clokep deleted the clokep/async-e2e branch July 15, 2020 12:49
@clokep clokep mentioned this pull request Jul 30, 2020
48 tasks
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit 'a973bcb8a':
  Add some tiny type annotations (#7870)
  Remove obsolete comment.
  Ensure that calls to `json.dumps` are compatible with the standard library json. (#7836)
  Avoid brand new rooms in `delete_old_current_state_events` (#7854)
  Allow accounts to be re-activated from the admin APIs. (#7847)
  Fix tests
  Fix typo
  Newsfile
  Use get_users_in_room rather than state handler in typing for speed
  Fix client reader sharding tests (#7853)
  Convert E2E key and room key handlers to async/await. (#7851)
  Return the proper 403 Forbidden error during errors with JWT logins. (#7844)
  remove `retry_on_integrity_error` wrapper for persist_events (#7848)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants