Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Convert device handler to async/await #7871

Merged
merged 5 commits into from
Jul 17, 2020
Merged

Convert device handler to async/await #7871

merged 5 commits into from
Jul 17, 2020

Conversation

clokep
Copy link
Member

@clokep clokep commented Jul 16, 2020

A lot of this is pretty normal, but there's a few things to note:

  • A couple spots we were yielding on functions that returned normal values.
  • A bunch of tests were fixed to add defer.succeed or defer.ensureDeferred.
  • The Signal / Distributor code was updated to properly handle receiving an awaitable (by using defer.ensureDeferred, which feels non-ideal, but I think we can fix this in the future?)

@clokep clokep requested a review from a team July 16, 2020 14:22
@clokep clokep merged commit 6b3ac3b into develop Jul 17, 2020
@clokep clokep deleted the clokep/async-devices branch July 17, 2020 11:09
@clokep clokep mentioned this pull request Jul 30, 2020
48 tasks
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit 'de119063f': (31 commits)
  Convert room list handler to async/await. (#7912)
  Element CSS and logo in email templates (#7919)
  Lint the contrib/ directory in CI and linting scripts, add synctl to linting script (#7914)
  Remove unused code from synapse.logging.utils. (#7897)
  Fix a typo in the sample config. (#7890)
  Fix deprecation warning: import ABC from collections.abc (#7892)
  Change sample config's postgres user to synapse_user (#7889)
  Fix deprecation warning due to invalid escape sequences (#7895)
  Remove Ubuntu Eoan that is now EOL (#7888)
  Fix the trace function for async functions. (#7872)
  Add help for creating a user via docker (#7885)
  Switch to Debian:Slim from Alpine for the docker image (#7839)
  Stop using 'device_max_stream_id' (#7882)
  Fix TypeError in synapse.notifier (#7880)
  Add a default limit (of 100) to get/sync operations. (#7858)
  Change "unknown room ver" logging to warning. (#7881)
  Convert device handler to async/await (#7871)
  Convert synapse.app to async/await. (#7868)
  Convert _base, profile, and _receipts handlers to async/await (#7860)
  Add admin endpoint to get members in a room. (#7842)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants