Admin API for reported events #8217

dklimpel · 2020-08-31T20:25:11Z

Add an admin API to read entries of table event_reports.
API: GET /_synapse/admin/v1/event_reports

Pull Request Checklist

Pull request is based on the develop branch
Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
Pull request includes a sign off
Code style is correct (run the linters)

Signed-off-by: Dirk Klimpel dirk@klimpel.org

Related to: #4007

Add an admin API to read entries of table `event_reports`. API: `GET /_synapse/admin/v1/event_reports`

anoadragon453

Thanks, I will this will be really useful :)

docs/admin_api/event_reports.rst

tests/rest/admin/test_event_reports.py

anoadragon453 · 2020-09-04T10:48:51Z

synapse/rest/admin/event_reports.py

+    async def on_GET(self, request):
+        await assert_requester_is_admin(self.auth, request)
+
+        start = parse_integer(request, "from", default=0)


We may want to do some basic error checking for negative from values. SQLite3 won't mind (will treat it as 0, but Postgres will raise an error).

anoadragon453 · 2020-09-04T10:51:07Z

synapse/rest/admin/event_reports.py

+            start, limit, user_id, room_id
+        )
+        ret = {"event_reports": event_reports, "total": total}
+        if len(event_reports) >= limit:


len(event_reports) should hopefully never be greater than limit. Perhaps you meant if start + len(event_reports) < total:?

You can find the same code here:

synapse/synapse/rest/admin/users.py

Lines 100 to 102 in 97962ad

ret = {"users": users, "total": total}

if len(users) >= limit:

ret["next_token"] = str(start + len(users))

If len(event_reports) equals limit you will get more results on next page.

I see, this was a bit confusing. == is really the case we care about here, but we're doing >= for safety.

So... does this mean if there are 100 reports, and we set a limit of 100, we'll get a next_token that doesn't actually show any more reports?

Oh. There is a bug. You are right. I will add a test.

I'm not sure. Should be next_token an integer or string?
In the user api it is a string:

synapse/synapse/rest/admin/users.py

Line 102 in babc027

ret["next_token"] = str(start + len(users))

In room api an integer:

synapse/synapse/rest/admin/rooms.py

Line 205 in babc027

response["next_batch"] = start + limit

Generally we prefer pagination tokens to be strings, so that we can encode extra data into them if necessary.

However, considering we're not very likely to do that here, and it would be unfortunate to have one admin API with a string pagination token, and another with an int one: I'd keep it as int for now.

In the future if we need to encode extra data for some reason, we'll just bump the endpoint version.

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

clokep · 2020-09-04T17:41:02Z

@dklimpel I see that you pushed some commits, is this ready for another review?

dklimpel · 2020-09-04T17:54:14Z

No, it is not ready for another review. I will add some more commits.

clokep · 2020-09-04T18:00:31Z

Great! Just let us know when it's ready. 👍

ThoreKr · 2020-09-04T21:20:33Z

How is this API intended to be used?

In itself the information provided by the event_reports table isn't really helpful for administrators or moderators.
Is it expected to add additional API calls or database lookups to get the sender or maybe even the complete message (if available) or would it be better to include this information into the report repsonse itself?

I currently have a query which looks like this:

SELECT event_reports.received_ts, event_reports.room_id, room_aliases.room_alias, events.sender, event_reports.user_id, event_reports.reason, event_json.json from event_reports left join room_aliases on room_aliases.room_id = event_reports.room_id join events on events.event_id = event_reports.event_id join event_json on event_json.event_id = event_reports.event_id;

The event json is definitely arguable and I haven't found a better way to include this information yet.

However, I'd really like to see at least the sender (the user being reported) to be part of the response. Room alias may be optional but helpful.

dklimpel · 2020-09-07T15:04:49Z

How is this API intended to be used?

In itself the information provided by the event_reports table isn't really helpful for administrators or moderators.
Is it expected to add additional API calls or database lookups to get the sender or maybe even the complete message (if available) or would it be better to include this information into the report repsonse itself?

I currently have a query which looks like this:
SELECT event_reports.received_ts, event_reports.room_id, room_aliases.room_alias, events.sender, event_reports.user_id, event_reports.reason, event_json.json from event_reports left join room_aliases on room_aliases.room_id = event_reports.room_id join events on events.event_id = event_reports.event_id join event_json on event_json.event_id = event_reports.event_id;
The event json is definitely arguable and I haven't found a better way to include this information yet.

However, I'd really like to see at least the sender (the user being reported) to be part of the response. Room alias may be optional but helpful.

The intention of the API is to use the provided function (abuse report) of synapse as admin without having to access the database via SQL. This will be version 1. The API can be improved or extended in the future.
Thank you for the SQL query. I will see if I can add it to the code.

dklimpel · 2020-09-12T20:29:01Z

Great! Just let us know when it's ready. 👍

@clokep It is ready for review now.

ThoreKr · 2020-09-14T17:20:37Z

docs/admin_api/event_reports.rst

+- ``reason``: Comment made by the ``user_id`` in this report.
+- ``content``: Content of reported event.
+- ``sender``: This is the ID of the user who sent the original message/event that was reported.
+- ``room_alias``: The alias of the room.


Should it be mentioned here, that this field can be null, if no room alias is specified (e.g. in direct messages)?

Sounds helpful. I would write something like "The alias of the room. null if the room does not have a canonical alias set."

anoadragon453

Apologies for the wait. Only a couple smaller things this time.

anoadragon453 · 2020-09-18T17:06:57Z

docs/admin_api/event_reports.rst

+- ``reason``: Comment made by the ``user_id`` in this report.
+- ``content``: Content of reported event.
+- ``sender``: This is the ID of the user who sent the original message/event that was reported.
+- ``room_alias``: The alias of the room.


Sounds helpful. I would write something like "The alias of the room. null if the room does not have a canonical alias set."

docs/admin_api/event_reports.rst

synapse/rest/admin/event_reports.py

anoadragon453 · 2020-09-18T17:26:03Z

synapse/rest/admin/event_reports.py

+            start, limit, user_id, room_id
+        )
+        ret = {"event_reports": event_reports, "total": total}
+        if len(event_reports) >= limit:


I see, this was a bit confusing. == is really the case we care about here, but we're doing >= for safety.

So... does this mean if there are 100 reports, and we set a limit of 100, we'll get a next_token that doesn't actually show any more reports?

synapse/storage/databases/main/room.py

tests/rest/admin/test_event_reports.py

docs/admin_api/event_reports.rst

anoadragon453

Minor things, otherwise lgtm!

dklimpel · 2020-09-22T06:32:40Z

@anoadragon453 Do you have an opinion about this: #8217 (comment) ?

anoadragon453

LGTM!

@dklimpel

Synapse 1.21.0rc1 (2020-10-01) ============================== Features -------- - Require the user to confirm that their password should be reset after clicking the email confirmation link. ([\#8004](#8004)) - Add an admin API `GET /_synapse/admin/v1/event_reports` to read entries of table `event_reports`. Contributed by @dklimpel. ([\#8217](#8217)) - Consolidate the SSO error template across all configuration. ([\#8248](#8248), [\#8405](#8405)) - Add a configuration option to specify a whitelist of domains that a user can be redirected to after validating their email or phone number. ([\#8275](#8275), [\#8417](#8417)) - Add experimental support for sharding event persister. ([\#8294](#8294), [\#8387](#8387), [\#8396](#8396), [\#8419](#8419)) - Add the room topic and avatar to the room details admin API. ([\#8305](#8305)) - Add an admin API for querying rooms where a user is a member. Contributed by @dklimpel. ([\#8306](#8306)) - Add `uk.half-shot.msc2778.login.application_service` login type to allow appservices to login. ([\#8320](#8320)) - Add a configuration option that allows existing users to log in with OpenID Connect. Contributed by @BBBSnowball and @OmmyZhang. ([\#8345](#8345)) - Add prometheus metrics for replication requests. ([\#8406](#8406)) - Support passing additional single sign-on parameters to the client. ([\#8413](#8413)) - Add experimental reporting of metrics on expensive rooms for state-resolution. ([\#8420](#8420)) - Add experimental prometheus metric to track numbers of "large" rooms for state resolutiom. ([\#8425](#8425)) - Add prometheus metrics to track federation delays. ([\#8430](#8430)) Bugfixes -------- - Fix a bug in the media repository where remote thumbnails with the same size but different crop methods would overwrite each other. Contributed by @deepbluev7. ([\#7124](#7124)) - Fix inconsistent handling of non-existent push rules, and stop tracking the `enabled` state of removed push rules. ([\#7796](#7796)) - Fix a longstanding bug when storing a media file with an empty `upload_name`. ([\#7905](#7905)) - Fix messages not being sent over federation until an event is sent into the same room. ([\#8230](#8230), [\#8247](#8247), [\#8258](#8258), [\#8272](#8272), [\#8322](#8322)) - Fix a longstanding bug where files that could not be thumbnailed would result in an Internal Server Error. ([\#8236](#8236), [\#8435](#8435)) - Upgrade minimum version of `canonicaljson` to version 1.4.0, to fix an unicode encoding issue. ([\#8262](#8262)) - Fix longstanding bug which could lead to incomplete database upgrades on SQLite. ([\#8265](#8265)) - Fix stack overflow when stderr is redirected to the logging system, and the logging system encounters an error. ([\#8268](#8268)) - Fix a bug which cause the logging system to report errors, if `DEBUG` was enabled and no `context` filter was applied. ([\#8278](#8278)) - Fix edge case where push could get delayed for a user until a later event was pushed. ([\#8287](#8287)) - Fix fetching malformed events from remote servers. ([\#8324](#8324)) - Fix `UnboundLocalError` from occuring when appservices send a malformed register request. ([\#8329](#8329)) - Don't send push notifications to expired user accounts. ([\#8353](#8353)) - Fix a regression in v1.19.0 with reactivating users through the admin API. ([\#8362](#8362)) - Fix a bug where during device registration the length of the device name wasn't limited. ([\#8364](#8364)) - Include `guest_access` in the fields that are checked for null bytes when updating `room_stats_state`. Broke in v1.7.2. ([\#8373](#8373)) - Fix theoretical race condition where events are not sent down `/sync` if the synchrotron worker is restarted without restarting other workers. ([\#8374](#8374)) - Fix a bug which could cause errors in rooms with malformed membership events, on servers using sqlite. ([\#8385](#8385)) - Fix "Re-starting finished log context" warning when receiving an event we already had over federation. ([\#8398](#8398)) - Fix incorrect handling of timeouts on outgoing HTTP requests. ([\#8400](#8400)) - Fix a regression in v1.20.0 in the `synapse_port_db` script regarding the `ui_auth_sessions_ips` table. ([\#8410](#8410)) - Remove unnecessary 3PID registration check when resetting password via an email address. Bug introduced in v0.34.0rc2. ([\#8414](#8414)) Improved Documentation ---------------------- - Add `/_synapse/client` to the reverse proxy documentation. ([\#8227](#8227)) - Add note to the reverse proxy settings documentation about disabling Apache's mod_security2. Contributed by Julian Fietkau (@jfietkau). ([\#8375](#8375)) - Improve description of `server_name` config option in `homserver.yaml`. ([\#8415](#8415)) Deprecations and Removals ------------------------- - Drop support for `prometheus_client` older than 0.4.0. ([\#8426](#8426)) Internal Changes ---------------- - Fix tests on distros which disable TLSv1.0. Contributed by @danc86. ([\#8208](#8208)) - Simplify the distributor code to avoid unnecessary work. ([\#8216](#8216)) - Remove the `populate_stats_process_rooms_2` background job and restore functionality to `populate_stats_process_rooms`. ([\#8243](#8243)) - Clean up type hints for `PaginationConfig`. ([\#8250](#8250), [\#8282](#8282)) - Track the latest event for every destination and room for catch-up after federation outage. ([\#8256](#8256)) - Fix non-user visible bug in implementation of `MultiWriterIdGenerator.get_current_token_for_writer`. ([\#8257](#8257)) - Switch to the JSON implementation from the standard library. ([\#8259](#8259)) - Add type hints to `synapse.util.async_helpers`. ([\#8260](#8260)) - Simplify tests that mock asynchronous functions. ([\#8261](#8261)) - Add type hints to `StreamToken` and `RoomStreamToken` classes. ([\#8279](#8279)) - Change `StreamToken.room_key` to be a `RoomStreamToken` instance. ([\#8281](#8281)) - Refactor notifier code to correctly use the max event stream position. ([\#8288](#8288)) - Use slotted classes where possible. ([\#8296](#8296)) - Support testing the local Synapse checkout against the [Complement homeserver test suite](https://github.com/matrix-org/complement/). ([\#8317](#8317)) - Update outdated usages of `metaclass` to python 3 syntax. ([\#8326](#8326)) - Move lint-related dependencies to package-extra field, update CONTRIBUTING.md to utilise this. ([\#8330](#8330), [\#8377](#8377)) - Use the `admin_patterns` helper in additional locations. ([\#8331](#8331)) - Fix test logging to allow braces in log output. ([\#8335](#8335)) - Remove `__future__` imports related to Python 2 compatibility. ([\#8337](#8337)) - Simplify `super()` calls to Python 3 syntax. ([\#8344](#8344)) - Fix bad merge from `release-v1.20.0` branch to `develop`. ([\#8354](#8354)) - Factor out a `_send_dummy_event_for_room` method. ([\#8370](#8370)) - Improve logging of state resolution. ([\#8371](#8371)) - Add type annotations to `SimpleHttpClient`. ([\#8372](#8372)) - Refactor ID generators to use `async with` syntax. ([\#8383](#8383)) - Add `EventStreamPosition` type. ([\#8388](#8388)) - Create a mechanism for marking tests "logcontext clean". ([\#8399](#8399)) - A pair of tiny cleanups in the federation request code. ([\#8401](#8401)) - Add checks on startup that PostgreSQL sequences are consistent with their associated tables. ([\#8402](#8402)) - Do not include appservice users when calculating the total MAU for a server. ([\#8404](#8404)) - Typing fixes for `synapse.handlers.federation`. ([\#8422](#8422)) - Various refactors to simplify stream token handling. ([\#8423](#8423)) - Make stream token serializing/deserializing async. ([\#8427](#8427))

@dklimpel

Synapse 1.21.2 (2020-10-15) =========================== Debian packages and Docker images have been rebuilt using the latest versions of dependency libraries, including authlib 0.15.1. Please see bugfixes below. Security advisory ----------------- * HTML pages served via Synapse were vulnerable to cross-site scripting (XSS) attacks. All server administrators are encouraged to upgrade. ([\#8444](matrix-org/synapse#8444)) ([CVE-2020-26891](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-26891)) This fix was originally included in v1.21.0 but was missing a security advisory. This was reported by [Denis Kasak](https://github.com/dkasak). Bugfixes -------- - Fix rare bug where sending an event would fail due to a racey assertion. ([\#8530](matrix-org/synapse#8530)) - An updated version of the authlib dependency is included in the Docker and Debian images to fix an issue using OpenID Connect. See [\#8534](matrix-org/synapse#8534) for details. Synapse 1.21.1 (2020-10-13) =========================== This release fixes a regression in v1.21.0 that prevented debian packages from being built. It is otherwise identical to v1.21.0. Synapse 1.21.0 (2020-10-12) =========================== No significant changes since v1.21.0rc3. As [noted in v1.20.0](https://github.com/matrix-org/synapse/blob/release-v1.21.0/CHANGES.md#synapse-1200-2020-09-22), a future release will drop support for accessing Synapse's [Admin API](https://github.com/matrix-org/synapse/tree/master/docs/admin_api) under the `/_matrix/client/*` endpoint prefixes. At that point, the Admin API will only be accessible under `/_synapse/admin`. Synapse 1.21.0rc3 (2020-10-08) ============================== Bugfixes -------- - Fix duplication of events on high traffic servers, caused by PostgreSQL `could not serialize access due to concurrent update` errors. ([\#8456](matrix-org/synapse#8456)) Internal Changes ---------------- - Add Groovy Gorilla to the list of distributions we build `.deb`s for. ([\#8475](matrix-org/synapse#8475)) Synapse 1.21.0rc2 (2020-10-02) ============================== Features -------- - Convert additional templates from inline HTML to Jinja2 templates. ([\#8444](matrix-org/synapse#8444)) Bugfixes -------- - Fix a regression in v1.21.0rc1 which broke thumbnails of remote media. ([\#8438](matrix-org/synapse#8438)) - Do not expose the experimental `uk.half-shot.msc2778.login.application_service` flow in the login API, which caused a compatibility problem with Element iOS. ([\#8440](matrix-org/synapse#8440)) - Fix malformed log line in new federation "catch up" logic. ([\#8442](matrix-org/synapse#8442)) - Fix DB query on startup for negative streams which caused long start up times. Introduced in [\#8374](matrix-org/synapse#8374). ([\#8447](matrix-org/synapse#8447)) Synapse 1.21.0rc1 (2020-10-01) ============================== Features -------- - Require the user to confirm that their password should be reset after clicking the email confirmation link. ([\#8004](matrix-org/synapse#8004)) - Add an admin API `GET /_synapse/admin/v1/event_reports` to read entries of table `event_reports`. Contributed by @dklimpel. ([\#8217](matrix-org/synapse#8217)) - Consolidate the SSO error template across all configuration. ([\#8248](matrix-org/synapse#8248), [\#8405](matrix-org/synapse#8405)) - Add a configuration option to specify a whitelist of domains that a user can be redirected to after validating their email or phone number. ([\#8275](matrix-org/synapse#8275), [\#8417](matrix-org/synapse#8417)) - Add experimental support for sharding event persister. ([\#8294](matrix-org/synapse#8294), [\#8387](matrix-org/synapse#8387), [\#8396](matrix-org/synapse#8396), [\#8419](matrix-org/synapse#8419)) - Add the room topic and avatar to the room details admin API. ([\#8305](matrix-org/synapse#8305)) - Add an admin API for querying rooms where a user is a member. Contributed by @dklimpel. ([\#8306](matrix-org/synapse#8306)) - Add `uk.half-shot.msc2778.login.application_service` login type to allow appservices to login. ([\#8320](matrix-org/synapse#8320)) - Add a configuration option that allows existing users to log in with OpenID Connect. Contributed by @BBBSnowball and @OmmyZhang. ([\#8345](matrix-org/synapse#8345)) - Add prometheus metrics for replication requests. ([\#8406](matrix-org/synapse#8406)) - Support passing additional single sign-on parameters to the client. ([\#8413](matrix-org/synapse#8413)) - Add experimental reporting of metrics on expensive rooms for state-resolution. ([\#8420](matrix-org/synapse#8420)) - Add experimental prometheus metric to track numbers of "large" rooms for state resolutiom. ([\#8425](matrix-org/synapse#8425)) - Add prometheus metrics to track federation delays. ([\#8430](matrix-org/synapse#8430)) Bugfixes -------- - Fix a bug in the media repository where remote thumbnails with the same size but different crop methods would overwrite each other. Contributed by @deepbluev7. ([\#7124](matrix-org/synapse#7124)) - Fix inconsistent handling of non-existent push rules, and stop tracking the `enabled` state of removed push rules. ([\#7796](matrix-org/synapse#7796)) - Fix a longstanding bug when storing a media file with an empty `upload_name`. ([\#7905](matrix-org/synapse#7905)) - Fix messages not being sent over federation until an event is sent into the same room. ([\#8230](matrix-org/synapse#8230), [\#8247](matrix-org/synapse#8247), [\#8258](matrix-org/synapse#8258), [\#8272](matrix-org/synapse#8272), [\#8322](matrix-org/synapse#8322)) - Fix a longstanding bug where files that could not be thumbnailed would result in an Internal Server Error. ([\#8236](matrix-org/synapse#8236), [\#8435](matrix-org/synapse#8435)) - Upgrade minimum version of `canonicaljson` to version 1.4.0, to fix an unicode encoding issue. ([\#8262](matrix-org/synapse#8262)) - Fix longstanding bug which could lead to incomplete database upgrades on SQLite. ([\#8265](matrix-org/synapse#8265)) - Fix stack overflow when stderr is redirected to the logging system, and the logging system encounters an error. ([\#8268](matrix-org/synapse#8268)) - Fix a bug which cause the logging system to report errors, if `DEBUG` was enabled and no `context` filter was applied. ([\#8278](matrix-org/synapse#8278)) - Fix edge case where push could get delayed for a user until a later event was pushed. ([\#8287](matrix-org/synapse#8287)) - Fix fetching malformed events from remote servers. ([\#8324](matrix-org/synapse#8324)) - Fix `UnboundLocalError` from occuring when appservices send a malformed register request. ([\#8329](matrix-org/synapse#8329)) - Don't send push notifications to expired user accounts. ([\#8353](matrix-org/synapse#8353)) - Fix a regression in v1.19.0 with reactivating users through the admin API. ([\#8362](matrix-org/synapse#8362)) - Fix a bug where during device registration the length of the device name wasn't limited. ([\#8364](matrix-org/synapse#8364)) - Include `guest_access` in the fields that are checked for null bytes when updating `room_stats_state`. Broke in v1.7.2. ([\#8373](matrix-org/synapse#8373)) - Fix theoretical race condition where events are not sent down `/sync` if the synchrotron worker is restarted without restarting other workers. ([\#8374](matrix-org/synapse#8374)) - Fix a bug which could cause errors in rooms with malformed membership events, on servers using sqlite. ([\#8385](matrix-org/synapse#8385)) - Fix "Re-starting finished log context" warning when receiving an event we already had over federation. ([\#8398](matrix-org/synapse#8398)) - Fix incorrect handling of timeouts on outgoing HTTP requests. ([\#8400](matrix-org/synapse#8400)) - Fix a regression in v1.20.0 in the `synapse_port_db` script regarding the `ui_auth_sessions_ips` table. ([\#8410](matrix-org/synapse#8410)) - Remove unnecessary 3PID registration check when resetting password via an email address. Bug introduced in v0.34.0rc2. ([\#8414](matrix-org/synapse#8414)) Improved Documentation ---------------------- - Add `/_synapse/client` to the reverse proxy documentation. ([\#8227](matrix-org/synapse#8227)) - Add note to the reverse proxy settings documentation about disabling Apache's mod_security2. Contributed by Julian Fietkau (@jfietkau). ([\#8375](matrix-org/synapse#8375)) - Improve description of `server_name` config option in `homserver.yaml`. ([\#8415](matrix-org/synapse#8415)) Deprecations and Removals ------------------------- - Drop support for `prometheus_client` older than 0.4.0. ([\#8426](matrix-org/synapse#8426)) Internal Changes ---------------- - Fix tests on distros which disable TLSv1.0. Contributed by @danc86. ([\#8208](matrix-org/synapse#8208)) - Simplify the distributor code to avoid unnecessary work. ([\#8216](matrix-org/synapse#8216)) - Remove the `populate_stats_process_rooms_2` background job and restore functionality to `populate_stats_process_rooms`. ([\#8243](matrix-org/synapse#8243)) - Clean up type hints for `PaginationConfig`. ([\#8250](matrix-org/synapse#8250), [\#8282](matrix-org/synapse#8282)) - Track the latest event for every destination and room for catch-up after federation outage. ([\#8256](matrix-org/synapse#8256)) - Fix non-user visible bug in implementation of `MultiWriterIdGenerator.get_current_token_for_writer`. ([\#8257](matrix-org/synapse#8257)) - Switch to the JSON implementation from the standard library. ([\#8259](matrix-org/synapse#8259)) - Add type hints to `synapse.util.async_helpers`. ([\#8260](matrix-org/synapse#8260)) - Simplify tests that mock asynchronous functions. ([\#8261](matrix-org/synapse#8261)) - Add type hints to `StreamToken` and `RoomStreamToken` classes. ([\#8279](matrix-org/synapse#8279)) - Change `StreamToken.room_key` to be a `RoomStreamToken` instance. ([\#8281](matrix-org/synapse#8281)) - Refactor notifier code to correctly use the max event stream position. ([\#8288](matrix-org/synapse#8288)) - Use slotted classes where possible. ([\#8296](matrix-org/synapse#8296)) - Support testing the local Synapse checkout against the [Complement homeserver test suite](https://github.com/matrix-org/complement/). ([\#8317](matrix-org/synapse#8317)) - Update outdated usages of `metaclass` to python 3 syntax. ([\#8326](matrix-org/synapse#8326)) - Move lint-related dependencies to package-extra field, update CONTRIBUTING.md to utilise this. ([\#8330](matrix-org/synapse#8330), [\#8377](matrix-org/synapse#8377)) - Use the `admin_patterns` helper in additional locations. ([\#8331](matrix-org/synapse#8331)) - Fix test logging to allow braces in log output. ([\#8335](matrix-org/synapse#8335)) - Remove `__future__` imports related to Python 2 compatibility. ([\#8337](matrix-org/synapse#8337)) - Simplify `super()` calls to Python 3 syntax. ([\#8344](matrix-org/synapse#8344)) - Fix bad merge from `release-v1.20.0` branch to `develop`. ([\#8354](matrix-org/synapse#8354)) - Factor out a `_send_dummy_event_for_room` method. ([\#8370](matrix-org/synapse#8370)) - Improve logging of state resolution. ([\#8371](matrix-org/synapse#8371)) - Add type annotations to `SimpleHttpClient`. ([\#8372](matrix-org/synapse#8372)) - Refactor ID generators to use `async with` syntax. ([\#8383](matrix-org/synapse#8383)) - Add `EventStreamPosition` type. ([\#8388](matrix-org/synapse#8388)) - Create a mechanism for marking tests "logcontext clean". ([\#8399](matrix-org/synapse#8399)) - A pair of tiny cleanups in the federation request code. ([\#8401](matrix-org/synapse#8401)) - Add checks on startup that PostgreSQL sequences are consistent with their associated tables. ([\#8402](matrix-org/synapse#8402)) - Do not include appservice users when calculating the total MAU for a server. ([\#8404](matrix-org/synapse#8404)) - Typing fixes for `synapse.handlers.federation`. ([\#8422](matrix-org/synapse#8422)) - Various refactors to simplify stream token handling. ([\#8423](matrix-org/synapse#8423)) - Make stream token serializing/deserializing async. ([\#8427](matrix-org/synapse#8427))

) Split admin API for reported events in detail und list view. API was introduced with #8217 in synapse v.1.21.0. It makes the list (`GET /_synapse/admin/v1/event_reports`) less complex and provides a better overview. The details can be queried with: `GET /_synapse/admin/v1/event_reports/<report_id>`. It is similar to room and users API. It is a kind of regression in `GET /_synapse/admin/v1/event_reports`. `event_json` was removed. But the api was introduced one version before and it is an admin API (not under spec). Signed-off-by: Dirk Klimpel dirk@klimpel.org

* commit '4325be1a5': Fix missing null character check on guest_access room state Fixed a bug with reactivating users with the admin API (#8362) Admin API for reported events (#8217) Fix wording of deprecation notice in changelog Deprecation warning for synapse admin api being accessible under /_matrix Create function to check for long names in devices (#8364) Add a comment re #1691 Fix a bad merge from release-v1.20.0. (#8354) Admin API for querying rooms where a user is a member (#8306) Catch-up after Federation Outage (bonus): Catch-up on Synapse Startup (#8322) Simplify super() calls to Python 3 syntax. (#8344) Allow appservice users to /login (#8320) Update test logging to be able to accept braces (#8335) Move lint dependencies to extras_require (#8330)

dklimpel added 2 commits August 31, 2020 22:22

Admin API for reported events

11105b7

Add an admin API to read entries of table `event_reports`. API: `GET /_synapse/admin/v1/event_reports`

Add changelog

f3a10fc

clokep requested a review from a team August 31, 2020 20:44

anoadragon453 suggested changes Sep 4, 2020

View reviewed changes

Apply suggestions from code review

66563b1

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

dklimpel added 3 commits September 7, 2020 23:26

A lot of updates after code review: Tests, validations, sort parameter

860bc4b

small typos

610bed3

Add the original event to the JSON response body

503539e

erikjohnston requested a review from a team September 14, 2020 08:51

ThoreKr reviewed Sep 14, 2020

View reviewed changes

anoadragon453 suggested changes Sep 18, 2020

View reviewed changes

Update docs, fix next_token, add test

286c84f

dklimpel requested a review from anoadragon453 September 19, 2020 14:28

anoadragon453 reviewed Sep 21, 2020

View reviewed changes

tests/rest/admin/test_event_reports.py Outdated Show resolved Hide resolved

tests/rest/admin/test_event_reports.py Outdated Show resolved Hide resolved

docs/admin_api/event_reports.rst Outdated Show resolved Hide resolved

anoadragon453 suggested changes Sep 21, 2020

View reviewed changes

Changed ` to

72cdbc1

dklimpel requested a review from anoadragon453 September 22, 2020 06:33

Small typo in spelling

d60c707

anoadragon453 approved these changes Sep 22, 2020

View reviewed changes

anoadragon453 merged commit 4da01f9 into matrix-org:develop Sep 22, 2020

anoadragon453 mentioned this pull request Sep 22, 2020

event reports get lost in a database table #4007

Closed

dklimpel deleted the admin_api_report_events branch September 22, 2020 17:28

samuel-p mentioned this pull request Sep 22, 2020

Add Moderation Tool Awesome-Technologies/synapse-admin#68

Closed

dklimpel mentioned this pull request Oct 14, 2020

Split admin API for reported events into a detail and a list view #8539

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Admin API for reported events #8217

Admin API for reported events #8217

dklimpel commented Aug 31, 2020 •

edited

Loading

anoadragon453 left a comment

anoadragon453 Sep 4, 2020

anoadragon453 Sep 4, 2020

dklimpel Sep 7, 2020

anoadragon453 Sep 18, 2020

dklimpel Sep 19, 2020

dklimpel Sep 19, 2020

anoadragon453 Sep 22, 2020

clokep commented Sep 4, 2020

dklimpel commented Sep 4, 2020

clokep commented Sep 4, 2020

ThoreKr commented Sep 4, 2020 •

edited

Loading

dklimpel commented Sep 7, 2020

dklimpel commented Sep 12, 2020

ThoreKr Sep 14, 2020

anoadragon453 Sep 18, 2020

anoadragon453 left a comment

anoadragon453 Sep 18, 2020

anoadragon453 Sep 18, 2020

anoadragon453 left a comment

dklimpel commented Sep 22, 2020

anoadragon453 left a comment

	ret = {"users": users, "total": total}
	if len(users) >= limit:
	ret["next_token"] = str(start + len(users))

Admin API for reported events #8217

Admin API for reported events #8217

Conversation

dklimpel commented Aug 31, 2020 • edited Loading

Pull Request Checklist

anoadragon453 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

clokep commented Sep 4, 2020

dklimpel commented Sep 4, 2020

clokep commented Sep 4, 2020

ThoreKr commented Sep 4, 2020 • edited Loading

dklimpel commented Sep 7, 2020

dklimpel commented Sep 12, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anoadragon453 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anoadragon453 left a comment

Choose a reason for hiding this comment

dklimpel commented Sep 22, 2020

anoadragon453 left a comment

Choose a reason for hiding this comment

dklimpel commented Aug 31, 2020 •

edited

Loading

ThoreKr commented Sep 4, 2020 •

edited

Loading