Dehydrated devices #8380

uhoreg · 2020-09-22T22:33:47Z

Implements an alternate API for dehydration (compare with #7955)

Still needs unit tests, and is completely untested, but should be good enough to compare with 7955.

The idea is that the user first logs in as normal. They then call GET unstable/org.matrix.msc2697.v2/restore_device to get the dehydrated device data. If they are able to dehydrate the device, they call POST unstable/org.matrix.msc2697.v2/restore_device to claim the dehydrated device, and the server tells them if they can use it or not.

… minor fixes

clokep · 2020-09-23T13:02:18Z

@uhoreg Thanks for taking a look at this!

My inclination is that this is simpler than #7955, but there could be gotchas I'm not seeing. It looks like much of the code here is identical to #7955, but we need to keep track of a bit less state. That seems like a good thing to me.

What are your thoughts on it? Do you see issues with this approach?

I didn't leave comments on any particular bits of code since I assumed you were looking for an overall approach. Let me know if you want a more thorough review!

uhoreg · 2020-09-23T14:17:38Z

@clokep Thanks for the quick review!

What are your thoughts on it? Do you see issues with this approach?

It definitely seems simpler. The only issues I can see are the ones that I've already expressed (synapse having some hidden assumption somewhere that device IDs don't change, and that we're handing an access token to clients and expecting them not to mix dehydration calls in with other calls), but the first concern is probably just paranoia, and the second concern probably isn't too bad.

clokep · 2020-09-29T14:40:23Z

Removing from my review queue since I believe I've provided feedback. Let me know if I'm mistaken!

clokep

Looks pretty good overall! I think most of my comments are straightforward, but let me know if there's questions!

changelog.d/8380.feature

synapse/storage/databases/main/registration.py

synapse/storage/databases/main/devices.py

synapse/rest/client/v2_alpha/devices.py

synapse/rest/client/v2_alpha/keys.py

Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>

clokep

I think there's a couple of bugs in the REST layer, but overall looks good.

synapse/rest/client/v2_alpha/devices.py

synapse/rest/client/v2_alpha/keys.py

tests/handlers/test_device.py

Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>

clokep · 2020-10-05T17:15:17Z

Note that this implements matrix-org/matrix-spec-proposals#2697

uhoreg · 2020-10-05T21:43:22Z

One more change before this get merged: I want to make it copy the device display name from the current device to the dehydrated device when you rehydrate.

clokep

Just a couple final nits! 👍

synapse/rest/client/v2_alpha/devices.py

synapse/handlers/device.py

clokep

Seems great. Were we going to add something to the list of experimental features or is that not necessary?

uhoreg · 2020-10-06T19:10:51Z

I don't think it's necessary. Clients can get by with just trying the endpoints and bailing if the endpoint doesn't exist.

uhoreg · 2020-10-06T23:30:16Z

Why does buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers keep failing? It's failing on a test that is unrelated to my change, and all the other runners succeeded. But I've re-run the test a few times and it's still failing. :-/

clokep · 2020-10-07T11:24:24Z

Why does buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers keep failing? It's failing on a test that is unrelated to my change, and all the other runners succeeded. But I've re-run the test a few times and it's still failing. :-/

See matrix-org/sytest#969.

I just kicked it off again though so it should be successful this time.

@Akkowicz

Synapse 1.22.0rc1 (2020-10-22) ============================== Features -------- - Add a configuration option for always using the "userinfo endpoint" for OpenID Connect. This fixes support for some identity providers, e.g. GitLab. Contributed by Benjamin Koch. ([\#7658](#7658)) - Add ability for `ThirdPartyEventRules` modules to query and manipulate whether a room is in the public rooms directory. ([\#8292](#8292), [\#8467](#8467)) - Add support for olm fallback keys ([MSC2732](matrix-org/matrix-spec-proposals#2732)). ([\#8312](#8312), [\#8501](#8501)) - Add support for running background tasks in a separate worker process. ([\#8369](#8369), [\#8458](#8458), [\#8489](#8489), [\#8513](#8513), [\#8544](#8544), [\#8599](#8599)) - Add support for device dehydration ([MSC2697](matrix-org/matrix-spec-proposals#2697)). ([\#8380](#8380)) - Add support for [MSC2409](matrix-org/matrix-spec-proposals#2409), which allows sending typing, read receipts, and presence events to appservices. ([\#8437](#8437), [\#8590](#8590)) - Change default room version to "6", per [MSC2788](matrix-org/matrix-spec-proposals#2788). ([\#8461](#8461)) - Add the ability to send non-membership events into a room via the `ModuleApi`. ([\#8479](#8479)) - Increase default upload size limit from 10M to 50M. Contributed by @Akkowicz. ([\#8502](#8502)) - Add support for modifying event content in `ThirdPartyRules` modules. ([\#8535](#8535), [\#8564](#8564)) Bugfixes -------- - Fix a longstanding bug where invalid ignored users in account data could break clients. ([\#8454](#8454)) - Fix a bug where backfilling a room with an event that was missing the `redacts` field would break. ([\#8457](#8457)) - Don't attempt to respond to some requests if the client has already disconnected. ([\#8465](#8465)) - Fix message duplication if something goes wrong after persisting the event. ([\#8476](#8476)) - Fix incremental sync returning an incorrect `prev_batch` token in timeline section, which when used to paginate returned events that were included in the incremental sync. Broken since v0.16.0. ([\#8486](#8486)) - Expose the `uk.half-shot.msc2778.login.application_service` to clients from the login API. This feature was added in v1.21.0, but was not exposed as a potential login flow. ([\#8504](#8504)) - Fix error code for `/profile/{userId}/displayname` to be `M_BAD_JSON`. ([\#8517](#8517)) - Fix a bug introduced in v1.7.0 that could cause Synapse to insert values from non-state `m.room.retention` events into the `room_retention` database table. ([\#8527](#8527)) - Fix not sending events over federation when using sharded event writers. ([\#8536](#8536)) - Fix a long standing bug where email notifications for encrypted messages were blank. ([\#8545](#8545)) - Fix increase in the number of `There was no active span...` errors logged when using OpenTracing. ([\#8567](#8567)) - Fix a bug that prevented errors encountered during execution of the `synapse_port_db` from being correctly printed. ([\#8585](#8585)) - Fix appservice transactions to only include a maximum of 100 persistent and 100 ephemeral events. ([\#8606](#8606)) Updates to the Docker image --------------------------- - Added multi-arch support (arm64,arm/v7) for the docker images. Contributed by @maquis196. ([\#7921](#7921)) - Add support for passing commandline args to the synapse process. Contributed by @samuel-p. ([\#8390](#8390)) Improved Documentation ---------------------- - Update the directions for using the manhole with coroutines. ([\#8462](#8462)) - Improve readme by adding new shield.io badges. ([\#8493](#8493)) - Added note about docker in manhole.md regarding which ip address to bind to. Contributed by @maquis196. ([\#8526](#8526)) - Document the new behaviour of the `allowed_lifetime_min` and `allowed_lifetime_max` settings in the room retention configuration. ([\#8529](#8529)) Deprecations and Removals ------------------------- - Drop unused `device_max_stream_id` table. ([\#8589](#8589)) Internal Changes ---------------- - Check for unreachable code with mypy. ([\#8432](#8432)) - Add unit test for event persister sharding. ([\#8433](#8433)) - Allow events to be sent to clients sooner when using sharded event persisters. ([\#8439](#8439), [\#8488](#8488), [\#8496](#8496), [\#8499](#8499)) - Configure `public_baseurl` when using demo scripts. ([\#8443](#8443)) - Add SQL logging on queries that happen during startup. ([\#8448](#8448)) - Speed up unit tests when using PostgreSQL. ([\#8450](#8450)) - Remove redundant database loads of stream_ordering for events we already have. ([\#8452](#8452)) - Reduce inconsistencies between codepaths for membership and non-membership events. ([\#8463](#8463)) - Combine `SpamCheckerApi` with the more generic `ModuleApi`. ([\#8464](#8464)) - Additional testing for `ThirdPartyEventRules`. ([\#8468](#8468)) - Add `-d` option to `./scripts-dev/lint.sh` to lint files that have changed since the last git commit. ([\#8472](#8472)) - Unblacklist some sytests. ([\#8474](#8474)) - Include the log level in the phone home stats. ([\#8477](#8477)) - Remove outdated sphinx documentation, scripts and configuration. ([\#8480](#8480)) - Clarify error message when plugin config parsers raise an error. ([\#8492](#8492)) - Remove the deprecated `Handlers` object. ([\#8494](#8494)) - Fix a threadsafety bug in unit tests. ([\#8497](#8497)) - Add user agent to user_daily_visits table. ([\#8503](#8503)) - Add type hints to various parts of the code base. ([\#8407](#8407), [\#8505](#8505), [\#8507](#8507), [\#8547](#8547), [\#8562](#8562), [\#8609](#8609)) - Remove unused code from the test framework. ([\#8514](#8514)) - Apply some internal fixes to the `HomeServer` class to make its code more idiomatic and statically-verifiable. ([\#8515](#8515)) - Factor out common code between `RoomMemberHandler._locally_reject_invite` and `EventCreationHandler.create_event`. ([\#8537](#8537)) - Improve database performance by executing more queries without starting transactions. ([\#8542](#8542)) - Rename `Cache` to `DeferredCache`, to better reflect its purpose. ([\#8548](#8548)) - Move metric registration code down into `LruCache`. ([\#8561](#8561), [\#8591](#8591)) - Replace `DeferredCache` with the lighter-weight `LruCache` where possible. ([\#8563](#8563)) - Add virtualenv-generated folders to `.gitignore`. ([\#8566](#8566)) - Add `get_immediate` method to `DeferredCache`. ([\#8568](#8568)) - Fix mypy not properly checking across the codebase, additionally, fix a typing assertion error in `handlers/auth.py`. ([\#8569](#8569)) - Fix `synmark` benchmark runner. ([\#8571](#8571)) - Modify `DeferredCache.get()` to return `Deferred`s instead of `ObservableDeferred`s. ([\#8572](#8572)) - Adjust a protocol-type definition to fit `sqlite3` assertions. ([\#8577](#8577)) - Support macOS on the `synmark` benchmark runner. ([\#8578](#8578)) - Update `mypy` static type checker to 0.790. ([\#8583](#8583), [\#8600](#8600)) - Re-organize the structured logging code to separate the TCP transport handling from the JSON formatting. ([\#8587](#8587)) - Remove extraneous unittest logging decorators from unit tests. ([\#8592](#8592)) - Minor optimisations in caching code. ([\#8593](#8593), [\#8594](#8594))

@Akkowicz

Synapse 1.22.0 (2020-10-27) =========================== No significant changes. Synapse 1.22.0rc2 (2020-10-26) ============================== Bugfixes -------- - Fix bugs where ephemeral events were not sent to appservices. Broke in v1.22.0rc1. ([\#8648](matrix-org/synapse#8648), [\#8656](matrix-org/synapse#8656)) - Fix `user_daily_visits` table to not have duplicate rows per user/device due to multiple user agents. Broke in v1.22.0rc1. ([\#8654](matrix-org/synapse#8654)) Synapse 1.22.0rc1 (2020-10-22) ============================== Features -------- - Add a configuration option for always using the "userinfo endpoint" for OpenID Connect. This fixes support for some identity providers, e.g. GitLab. Contributed by Benjamin Koch. ([\#7658](matrix-org/synapse#7658)) - Add ability for `ThirdPartyEventRules` modules to query and manipulate whether a room is in the public rooms directory. ([\#8292](matrix-org/synapse#8292), [\#8467](matrix-org/synapse#8467)) - Add support for olm fallback keys ([MSC2732](matrix-org/matrix-spec-proposals#2732)). ([\#8312](matrix-org/synapse#8312), [\#8501](matrix-org/synapse#8501)) - Add support for running background tasks in a separate worker process. ([\#8369](matrix-org/synapse#8369), [\#8458](matrix-org/synapse#8458), [\#8489](matrix-org/synapse#8489), [\#8513](matrix-org/synapse#8513), [\#8544](matrix-org/synapse#8544), [\#8599](matrix-org/synapse#8599)) - Add support for device dehydration ([MSC2697](matrix-org/matrix-spec-proposals#2697)). ([\#8380](matrix-org/synapse#8380)) - Add support for [MSC2409](matrix-org/matrix-spec-proposals#2409), which allows sending typing, read receipts, and presence events to appservices. ([\#8437](matrix-org/synapse#8437), [\#8590](matrix-org/synapse#8590)) - Change default room version to "6", per [MSC2788](matrix-org/matrix-spec-proposals#2788). ([\#8461](matrix-org/synapse#8461)) - Add the ability to send non-membership events into a room via the `ModuleApi`. ([\#8479](matrix-org/synapse#8479)) - Increase default upload size limit from 10M to 50M. Contributed by @Akkowicz. ([\#8502](matrix-org/synapse#8502)) - Add support for modifying event content in `ThirdPartyRules` modules. ([\#8535](matrix-org/synapse#8535), [\#8564](matrix-org/synapse#8564)) Bugfixes -------- - Fix a longstanding bug where invalid ignored users in account data could break clients. ([\#8454](matrix-org/synapse#8454)) - Fix a bug where backfilling a room with an event that was missing the `redacts` field would break. ([\#8457](matrix-org/synapse#8457)) - Don't attempt to respond to some requests if the client has already disconnected. ([\#8465](matrix-org/synapse#8465)) - Fix message duplication if something goes wrong after persisting the event. ([\#8476](matrix-org/synapse#8476)) - Fix incremental sync returning an incorrect `prev_batch` token in timeline section, which when used to paginate returned events that were included in the incremental sync. Broken since v0.16.0. ([\#8486](matrix-org/synapse#8486)) - Expose the `uk.half-shot.msc2778.login.application_service` to clients from the login API. This feature was added in v1.21.0, but was not exposed as a potential login flow. ([\#8504](matrix-org/synapse#8504)) - Fix error code for `/profile/{userId}/displayname` to be `M_BAD_JSON`. ([\#8517](matrix-org/synapse#8517)) - Fix a bug introduced in v1.7.0 that could cause Synapse to insert values from non-state `m.room.retention` events into the `room_retention` database table. ([\#8527](matrix-org/synapse#8527)) - Fix not sending events over federation when using sharded event writers. ([\#8536](matrix-org/synapse#8536)) - Fix a long standing bug where email notifications for encrypted messages were blank. ([\#8545](matrix-org/synapse#8545)) - Fix increase in the number of `There was no active span...` errors logged when using OpenTracing. ([\#8567](matrix-org/synapse#8567)) - Fix a bug that prevented errors encountered during execution of the `synapse_port_db` from being correctly printed. ([\#8585](matrix-org/synapse#8585)) - Fix appservice transactions to only include a maximum of 100 persistent and 100 ephemeral events. ([\#8606](matrix-org/synapse#8606)) Updates to the Docker image --------------------------- - Added multi-arch support (arm64,arm/v7) for the docker images. Contributed by @maquis196. ([\#7921](matrix-org/synapse#7921)) - Add support for passing commandline args to the synapse process. Contributed by @samuel-p. ([\#8390](matrix-org/synapse#8390)) Improved Documentation ---------------------- - Update the directions for using the manhole with coroutines. ([\#8462](matrix-org/synapse#8462)) - Improve readme by adding new shield.io badges. ([\#8493](matrix-org/synapse#8493)) - Added note about docker in manhole.md regarding which ip address to bind to. Contributed by @maquis196. ([\#8526](matrix-org/synapse#8526)) - Document the new behaviour of the `allowed_lifetime_min` and `allowed_lifetime_max` settings in the room retention configuration. ([\#8529](matrix-org/synapse#8529)) Deprecations and Removals ------------------------- - Drop unused `device_max_stream_id` table. ([\#8589](matrix-org/synapse#8589)) Internal Changes ---------------- - Check for unreachable code with mypy. ([\#8432](matrix-org/synapse#8432)) - Add unit test for event persister sharding. ([\#8433](matrix-org/synapse#8433)) - Allow events to be sent to clients sooner when using sharded event persisters. ([\#8439](matrix-org/synapse#8439), [\#8488](matrix-org/synapse#8488), [\#8496](matrix-org/synapse#8496), [\#8499](matrix-org/synapse#8499)) - Configure `public_baseurl` when using demo scripts. ([\#8443](matrix-org/synapse#8443)) - Add SQL logging on queries that happen during startup. ([\#8448](matrix-org/synapse#8448)) - Speed up unit tests when using PostgreSQL. ([\#8450](matrix-org/synapse#8450)) - Remove redundant database loads of stream_ordering for events we already have. ([\#8452](matrix-org/synapse#8452)) - Reduce inconsistencies between codepaths for membership and non-membership events. ([\#8463](matrix-org/synapse#8463)) - Combine `SpamCheckerApi` with the more generic `ModuleApi`. ([\#8464](matrix-org/synapse#8464)) - Additional testing for `ThirdPartyEventRules`. ([\#8468](matrix-org/synapse#8468)) - Add `-d` option to `./scripts-dev/lint.sh` to lint files that have changed since the last git commit. ([\#8472](matrix-org/synapse#8472)) - Unblacklist some sytests. ([\#8474](matrix-org/synapse#8474)) - Include the log level in the phone home stats. ([\#8477](matrix-org/synapse#8477)) - Remove outdated sphinx documentation, scripts and configuration. ([\#8480](matrix-org/synapse#8480)) - Clarify error message when plugin config parsers raise an error. ([\#8492](matrix-org/synapse#8492)) - Remove the deprecated `Handlers` object. ([\#8494](matrix-org/synapse#8494)) - Fix a threadsafety bug in unit tests. ([\#8497](matrix-org/synapse#8497)) - Add user agent to user_daily_visits table. ([\#8503](matrix-org/synapse#8503)) - Add type hints to various parts of the code base. ([\#8407](matrix-org/synapse#8407), [\#8505](matrix-org/synapse#8505), [\#8507](matrix-org/synapse#8507), [\#8547](matrix-org/synapse#8547), [\#8562](matrix-org/synapse#8562), [\#8609](matrix-org/synapse#8609)) - Remove unused code from the test framework. ([\#8514](matrix-org/synapse#8514)) - Apply some internal fixes to the `HomeServer` class to make its code more idiomatic and statically-verifiable. ([\#8515](matrix-org/synapse#8515)) - Factor out common code between `RoomMemberHandler._locally_reject_invite` and `EventCreationHandler.create_event`. ([\#8537](matrix-org/synapse#8537)) - Improve database performance by executing more queries without starting transactions. ([\#8542](matrix-org/synapse#8542)) - Rename `Cache` to `DeferredCache`, to better reflect its purpose. ([\#8548](matrix-org/synapse#8548)) - Move metric registration code down into `LruCache`. ([\#8561](matrix-org/synapse#8561), [\#8591](matrix-org/synapse#8591)) - Replace `DeferredCache` with the lighter-weight `LruCache` where possible. ([\#8563](matrix-org/synapse#8563)) - Add virtualenv-generated folders to `.gitignore`. ([\#8566](matrix-org/synapse#8566)) - Add `get_immediate` method to `DeferredCache`. ([\#8568](matrix-org/synapse#8568)) - Fix mypy not properly checking across the codebase, additionally, fix a typing assertion error in `handlers/auth.py`. ([\#8569](matrix-org/synapse#8569)) - Fix `synmark` benchmark runner. ([\#8571](matrix-org/synapse#8571)) - Modify `DeferredCache.get()` to return `Deferred`s instead of `ObservableDeferred`s. ([\#8572](matrix-org/synapse#8572)) - Adjust a protocol-type definition to fit `sqlite3` assertions. ([\#8577](matrix-org/synapse#8577)) - Support macOS on the `synmark` benchmark runner. ([\#8578](matrix-org/synapse#8578)) - Update `mypy` static type checker to 0.790. ([\#8583](matrix-org/synapse#8583), [\#8600](matrix-org/synapse#8600)) - Re-organize the structured logging code to separate the TCP transport handling from the JSON formatting. ([\#8587](matrix-org/synapse#8587)) - Remove extraneous unittest logging decorators from unit tests. ([\#8592](matrix-org/synapse#8592)) - Minor optimisations in caching code. ([\#8593](matrix-org/synapse#8593), [\#8594](matrix-org/synapse#8594))

uhoreg added 10 commits July 24, 2020 17:49

initial version of dehydration

52ddb79

run black

e60a99d

add changelog

0f9e402

minor fixes

b59bc66

maybe this will make lint happy?

96d9fc3

Merge remote-tracking branch 'origin/develop' into dehydration

460ebc5

newer version of dehydration proposal, add doc improvements and other…

c7c8f28

… minor fixes

fix nonexistent reference

b7398f7

implement alternative dehydration API

355f123

remove unneeded table

037c201

uhoreg requested a review from clokep September 22, 2020 22:38

move rest endpoint to devices and tweak endpoint names

a84e491

clokep removed their request for review September 29, 2020 14:40

uhoreg added 4 commits September 30, 2020 12:50

some fixes

24405c7

invalidate cache and clear old device when setting new device ID

bb7c732

run black

6110a6a

add unit tests

7029d97

uhoreg changed the title ~~[WIP] dehydrated devices (take 2)~~ Dehydrated devices Sep 30, 2020

uhoreg added 4 commits September 30, 2020 16:33

lint and fix changelog

90f42ad

Merge remote-tracking branch 'origin/develop' into dehydration2

3a27b74

adjust copyright headers

f63d6c0

black

2b30fc7

uhoreg requested a review from clokep September 30, 2020 21:36

clokep self-assigned this Oct 1, 2020

clokep mentioned this pull request Oct 1, 2020

[WIP] device dehydration #7955

Closed

clokep suggested changes Oct 1, 2020

View reviewed changes

Apply suggestions from code review

8e5ef16

Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>

apply suggestions from review

5935477

uhoreg marked this pull request as ready for review October 3, 2020 01:23

uhoreg requested a review from clokep October 3, 2020 01:23

clokep suggested changes Oct 5, 2020

View reviewed changes

synapse/rest/client/v2_alpha/devices.py Outdated Show resolved Hide resolved

synapse/rest/client/v2_alpha/devices.py Outdated Show resolved Hide resolved

synapse/rest/client/v2_alpha/keys.py Outdated Show resolved Hide resolved

tests/handlers/test_device.py Outdated Show resolved Hide resolved

clokep added the sponsored label Oct 5, 2020

Apply suggestions from code review

e69835e

Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>

fix a couple incorrect names

b934fde

uhoreg added 3 commits October 5, 2020 18:13

update display name when dehydrating device

0b34ac0

black

a87cb40

fix comments

2a10d7a

uhoreg requested a review from clokep October 5, 2020 23:41

uhoreg mentioned this pull request Oct 6, 2020

[WIP] MSC2697: Device dehydration matrix-org/matrix-spec-proposals#2697

Closed

clokep reviewed Oct 6, 2020

View reviewed changes

synapse/rest/client/v2_alpha/devices.py Outdated Show resolved Hide resolved

synapse/rest/client/v2_alpha/devices.py Outdated Show resolved Hide resolved

synapse/handlers/device.py Outdated Show resolved Hide resolved

synapse/handlers/device.py Outdated Show resolved Hide resolved

uhoreg added 2 commits October 6, 2020 13:25

apply changes from review

f37f6a0

Merge remote-tracking branch 'origin/develop' into dehydration2

92ba279

clokep approved these changes Oct 6, 2020

View reviewed changes

clokep merged commit 4cb44a1 into matrix-org:develop Oct 7, 2020

uhoreg mentioned this pull request Oct 7, 2020

Users in short-lived incognito tabs may never be able to share megolm keys, unless they can dehydrate/rehydrate their device somehow. element-hq/element-web#3825

Closed

callahad added the Z-Time-Tracked Element employees should track their time spent on this issue/PR. label Jan 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dehydrated devices #8380

Dehydrated devices #8380

uhoreg commented Sep 22, 2020

clokep commented Sep 23, 2020

uhoreg commented Sep 23, 2020

clokep commented Sep 29, 2020

clokep left a comment

clokep left a comment

clokep commented Oct 5, 2020

uhoreg commented Oct 5, 2020

clokep left a comment

clokep left a comment

uhoreg commented Oct 6, 2020

uhoreg commented Oct 6, 2020

clokep commented Oct 7, 2020

Dehydrated devices #8380

Dehydrated devices #8380

Conversation

uhoreg commented Sep 22, 2020

clokep commented Sep 23, 2020

uhoreg commented Sep 23, 2020

clokep commented Sep 29, 2020

clokep left a comment

Choose a reason for hiding this comment

clokep left a comment

Choose a reason for hiding this comment

clokep commented Oct 5, 2020

uhoreg commented Oct 5, 2020

clokep left a comment

Choose a reason for hiding this comment

clokep left a comment

Choose a reason for hiding this comment

uhoreg commented Oct 6, 2020

uhoreg commented Oct 6, 2020

clokep commented Oct 7, 2020