Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove redundant loads of stream_ordering for events #8452

Merged
merged 7 commits into from
Oct 5, 2020
Merged

Remove redundant loads of stream_ordering for events #8452

merged 7 commits into from
Oct 5, 2020

Commits on Oct 2, 2020

  1. Remove redundant loads of stream_ordering for events 

    If we already have the event, we already have its stream ordering.
    @richvdh
    richvdh committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    eb9ccc3 View commit details
    Browse the repository at this point in the history

  2. Remove stream ordering from Metadata dict 

    There's no need for it to be in the dict as well as the events table. Instead,
we store it in a separate attribute in the EventInternalMetadata object, and
populate that on load.

This means that we can rely on it being correctly populated for any event which
has been persited to the database.
    @richvdh
    richvdh committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    4c37299 View commit details
    Browse the repository at this point in the history

  3. Remove EventBase.stream_ordering 

    It's confusing here.
    @richvdh
    richvdh committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    2187fe2 View commit details
    Browse the repository at this point in the history

  4. mypy fixes

    @richvdh
    richvdh committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    4594e4b View commit details
    Browse the repository at this point in the history

  5. fixit

    @richvdh
    richvdh committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    d297188 View commit details
    Browse the repository at this point in the history

  6. fix for psql

    @richvdh
    richvdh committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    e8357a0 View commit details
    Browse the repository at this point in the history

  7. fix, yet again

    @richvdh
    richvdh committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    6230f13 View commit details
    Browse the repository at this point in the history