Add type hints for account validity handler

[clokep]

This adds type hints to the account validity handler and bled into the profile code a bit.

It fixes a couple of things:

• Proper types for profile display name / avatar URL.
• Proper handling of an account which doesn't expire, which is a "real" bug, but can only be caused by the admin API.

[clokep]

Or perhaps this should just raise an error instead of silently ignoring it?

[anoadragon453]

Yeahhh, it's probably poor form to return a 200 OK for a request that will never actually send the email.

At the same time, I could see raising an error potentially breaking someone's script that just loops over their entire userbase.

Perhaps we can raise an error and put out a notice in the release notes just in case?

[clokep]

I decided to make the changelog entry into a bugfix about this instead. Hopefully that's enough of a notice?

[clokep]

This comment seemed entirely wrong, it becomes a list of dictionaries like [{"user_id": "@foo:matrix.org", "expiration_time": 1234}].

Although converting this to be a flat dictionary like {"@foo:matrix.org": 1234} would probably make more sense.

[anoadragon453]

lgtm otherwise

[anoadragon453]

Yeahhh, it's probably poor form to return a 200 OK for a request that will never actually send the email.

At the same time, I could see raising an error potentially breaking someone's script that just loops over their entire userbase.

Perhaps we can raise an error and put out a notice in the release notes just in case?

[anoadragon453]

Looks better, thanks! Do you think we should still add a note to the changelog for this?

[clokep]

Do you think we should still add a note to the changelog for this?

I think renaming the changelog entry is enough.