Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Various clean-ups to the logging context code #8935

Merged
merged 6 commits into from
Dec 14, 2020
Merged

Various clean-ups to the logging context code #8935

merged 6 commits into from
Dec 14, 2020

Commits on Dec 14, 2020

  1. Remove dead code. 

    This code is never called as of #8607.
    @clokep
    clokep committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    68b40c3 View commit details
    Browse the repository at this point in the history

  2. Simplify the init args for LoggingContextFilter. 

    This makes the LoggingContextFilter a bit more specific, but the
flexibility was unused and this is a hot codepath.
    @clokep
    clokep committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    1bd6c9f View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary request kwarg in tests. 

    request is optional when making a LoggingContext, we should only be
providing it for tests that need it.
    @clokep
    clokep committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    9cb2a8a View commit details
    Browse the repository at this point in the history

  4. Remove the copy_to method from logging context. 

    copy_to was being used in two different ways (the target of copy_to
was completely different classes). This codes the simplified behavior
into each location:

* Copying from a parent to a child context during initialization.
* Copying properties from a logging context to a log record.

Note that with this change the "scope" is no longer copied to a
log record.
    @clokep
    clokep committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    7a7ea5f View commit details
    Browse the repository at this point in the history

  5. Pass in request to the log context constructor. 

    Simplify code by passing in request during initialization instead of
after the object has been created.
    @clokep
    clokep committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    a6a3629 View commit details
    Browse the repository at this point in the history

  6. Add newsfragment.

    @clokep
    clokep committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    911064c View commit details
    Browse the repository at this point in the history