Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Feature: Purge local room history. #911

Merged
merged 9 commits into from
Jul 7, 2016
Merged

Conversation

erikjohnston
Copy link
Member

No description provided.

max_depth = max(row[0] for row in rows)

if max_depth <= topological_ordering:
raise Exception("topological_ordering is greater than forward extremeties")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe 400 here rather than 500?
Maybe comment on why this is bad.

@NegativeMjark
Copy link
Contributor

NegativeMjark commented Jul 7, 2016

What happens when clients try to backfill using tokens from before the purge?

@erikjohnston
Copy link
Member Author

What happens when clients try to backfill using tokens from before the purge?

It (successfully) returns 0 events. It probably triggers backfill to remote servers, so eventually it would probably return some events once the sever had backpaginated enough.

@NegativeMjark
Copy link
Contributor

LGTM

@erikjohnston erikjohnston merged commit 70d650b into develop Jul 7, 2016
@rubo77
Copy link
Contributor

rubo77 commented Jul 10, 2016

Is this already a solution for #890 - delete old data to clean up database ?

@erikjohnston
Copy link
Member Author

@rubo77 Yes, though its only a basic, manual per room API atm

@4nd3r
Copy link
Contributor

4nd3r commented Aug 19, 2016

@erikjohnston is this manual per room API documented somewhere or can anyone can give an example?

@rubo77 rubo77 mentioned this pull request Aug 19, 2016
@rubo77
Copy link
Contributor

rubo77 commented Aug 19, 2016

In #916 I posted a gist, that could work. If it works, we should add that in the api-rst file

@erikjohnston
Copy link
Member Author

@rubo77
Copy link
Contributor

rubo77 commented Aug 19, 2016

@erikjohnston can you take part of my example gist from #916 into that documentation?

https://gist.github.com/rubo77/458eb4808d665e619feeaf556476f73f

@4nd3r
Copy link
Contributor

4nd3r commented Aug 20, 2016

@erikjohnston thanks. does this API also delete uploaded media from disk?

@rubo77
Copy link
Contributor

rubo77 commented Aug 20, 2016

I updated to 0.17 now, and now my gist file works fine

@rubo77
Copy link
Contributor

rubo77 commented Aug 21, 2016

#1034 will add an example to the API Documentation

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants