Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Enforce all replication HTTP clients calls use kwargs #9144

Merged
merged 3 commits into from
Jan 18, 2021
Merged

Enforce all replication HTTP clients calls use kwargs #9144

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
956b002
Enforce all replication HTTP clients calls use kwargs
erikjohnston Jan 18, 2021
030d83e
Newsfile
erikjohnston Jan 18, 2021
602a661
Merge remote-tracking branch 'origin/develop' into erikj/kwarg_http
erikjohnston Jan 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/9144.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Enforce that replication HTTP clients are called with keyword arguments only.
2 changes: 1 addition & 1 deletion synapse/replication/http/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ def make_client(cls, hs):

@trace(opname="outgoing_replication_request")
@outgoing_gauge.track_inprogress()
async def send_request(instance_name="master", **kwargs):
async def send_request(*, instance_name="master", **kwargs):
if instance_name == local_instance_name:
raise Exception("Trying to send HTTP request to self")
if instance_name == "master":
Expand Down