Parse ui_auth.session_timeout as a duration (instead of treating it as ms)

changelog.d/9426.misc

@@ -0,0 +1 @@
+Calling the 'parse_duration' function so that configs can be specified in terms of number of seconds/hours/etc/.

docs/sample_config.yaml

@@ -2241,6 +2241,9 @@ ui_auth:
     # seconds.
     #
     #session_timeout: 15000
+    # Now ui_auth also allow standard duration formats such as "15s" to allow
+    # for credential validation to last for 15 seconds.
+    # session_timeout: "15s"
 
 
 # Configuration for sending emails from Synapse.

synapse/config/auth.py

@@ -37,7 +37,9 @@ def read_config(self, config, **kwargs):
 
         # User-interactive authentication
         ui_auth = config.get("ui_auth") or {}
-        self.ui_auth_session_timeout = ui_auth.get("session_timeout", 0)
+        self.ui_auth_session_timeout = self.parse_duration(
+            ui_auth.get("session_timeout", 0)
+        )
 
     def generate_config_section(self, config_dir_path, server_name, **kwargs):
         return """\
@@ -106,4 +108,7 @@ def generate_config_section(self, config_dir_path, server_name, **kwargs):
             # seconds.
             #
             #session_timeout: 15000
+            # Now ui_auth also allow standard duration formats such as "15s" to allow
+            # for credential validation to last for 15 seconds.
+            # session_timeout: "15s"
         """

tests/rest/client/v2_alpha/test_auth.py

@@ -343,7 +343,7 @@ def test_cannot_change_uri(self):
             },
         )
 
-    @unittest.override_config({"ui_auth": {"session_timeout": 5 * 1000}})
+    @unittest.override_config({"ui_auth": {"session_timeout": "5s"}})
     def test_can_reuse_session(self):
         """
         The session can be reused if configured.