Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sytest asserts optional fields in /sync #913

Closed
timokoesters opened this issue Jul 11, 2020 · 4 comments · Fixed by #939
Closed

Sytest asserts optional fields in /sync #913

timokoesters opened this issue Jul 11, 2020 · 4 comments · Fixed by #939

Comments

@timokoesters
Copy link
Contributor

sytest/tests/10apidoc/03events-initial.pl

Line 231 in 24bc7c4

assert_json_keys( $body->{rooms}, qw( join invite leave ) );

@timokoesters
Copy link
Contributor Author

https://matrix.org/docs/spec/client_server/r0.6.1#get-matrix-client-r0-sync

@timokoesters
Copy link
Contributor Author

timokoesters commented Jul 11, 2020 •
edited
Loading

So join, invite, leave but also rooms and some others

@timokoesters
Copy link
Contributor Author

Implemented on our fork: https://github.com/valkum/sytest/pull/224/files

@clokep
Copy link
Member

clokep commented Aug 14, 2020

Any chance you'd be willing to PR changes back to make sytest more spec compliant?

@timokoesters timokoesters mentioned this issue Aug 23, 2020
Merged
@ShadowJonathan ShadowJonathan mentioned this issue Sep 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bad tests timokoesters/sytest
2 participants
@clokep @timokoesters