Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't expect optional keys in /sync responses #957

Open
ShadowJonathan opened this issue Sep 17, 2020 · 3 comments
Open

Don't expect optional keys in /sync responses #957

ShadowJonathan opened this issue Sep 17, 2020 · 3 comments

Comments

@ShadowJonathan
Copy link
Contributor

Describe the bug
The spec for /sync responses says that all keys except next_batch are optional, yet in many spots in sytest (illustrated by test failures down below) these keys are implicitly expected in the response.

Additional context
This is a blocker for matrix-org/synapse#8336.

Here is a buildkite build that details this problem.

@ShadowJonathan
Copy link
Contributor Author

#913 looks relevant to this.

@ShadowJonathan
Copy link
Contributor Author

Some additional context from Conduit about failing tests, some of these are possible to be fixed by this.

@clokep
Copy link
Member

clokep commented Jul 22, 2021

#1040 did some work on this, but from there:

It would partially fix #957, but I haven't gone into rooms and stripped those keys, so there may still be some dependencies there. Like room specific account data, summary, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants