Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix socket binding on macOS #1058

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Fix socket binding on macOS #1058

merged 1 commit into from
Jun 23, 2021

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Jun 18, 2021

Fix socket binding on macOS. Abstract namespaced sockets are only supported on Linux so moving the socket to a real temporary file.

Fix #1054

Dev notes

 # Clean up the socket file after we're done
   $poke_fut->on_done( sub {
      unlink($path) or die "$0: can't unlink $path: $!\n";
   });

Fix #1054

Abstract namespaced sockets are only supported on Linux
so moving the socket to a real temporary file.

 - https://apple.stackexchange.com/a/157509/164173
 - "abstract socket name, supported only on Linux", https://docs.racket-lang.org/unix-socket/index.html
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richvdh richvdh merged commit 4fa32d0 into develop Jun 23, 2021
@richvdh richvdh deleted the 1054-macos-compatible-socket branch June 23, 2021 10:33
@MadLittleMods
Copy link
Contributor Author

Thanks @richvdh 🦗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Socket error when starting Synapse - Cannot bind - No such file or directory
2 participants