Extend cross-room backfill request to work with different impls #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
commented
Aug 18, 2021
| @@ -338,7 +338,6 @@ sub mk_await_request_pair | |||
|
|
|||
| return $self->{$okey}{$ikey} = Future->new | |||
| ->on_cancel( sub { | |||
| warn "Cancelling unused $shortname await for @paramvalues"; | |||
There was a problem hiding this comment.
this was required because we now cancel the await_request_state_ids request if it is unused. That's normal behaviour, so we shouldn't warn on it.
|
this seems to be consistently failing CI with a test that isn't normally flaky. will take a closer look. |
Servers should not be *obliged* to send a `state_ids` request if it already has the `auth_events` of a given event.
richvdh
force-pushed
the
rav/unpick_update_auth_events_and_context_for_auth/4
branch
from
9566118
to
9766edd
Compare
|
[the flaky test was in fact flaky, fixed in #1126] |
erikjohnston
approved these changes
Aug 26, 2021
richvdh
deleted the
rav/unpick_update_auth_events_and_context_for_auth/4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Servers should not be obliged to send a
state_idsrequest if it already has theauth_eventsof a given event.based on #1126