Tests for returning room avatar URLs in /publicRooms #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
added a commit
to matrix-org/synapse
that referenced
this pull request
Dec 21, 2015
illicitonion
added a commit
to matrix-org/synapse
that referenced
this pull request
Dec 21, 2015
Return room avatar URLs in /publicRooms Spec: matrix-org/matrix-spec-proposals#244 Tests: matrix-org/sytest#121
|
LGTM |
| Future->needs_all( | ||
| matrix_create_room( $user, | ||
| visibility => "public", | ||
| room_alias_name => "nonworldreadable", |
There was a problem hiding this comment.
There's a slight danger of these "unique" alias names becoming fragile across many test files.
I don't have any better suggestion currently, but perhaps something to think about for the future. Maybe a fixture for allocating new unique alias names?
illicitonion
force-pushed
the
daniel/avatarurls
branch
from
e464c29
to
b914bb6
Compare
illicitonion
added a commit
that referenced
this pull request
Jan 5, 2016
Tests for returning room avatar URLs in /publicRooms Spec: matrix-org/matrix-spec-proposals#244 Impl: matrix-org/synapse#453
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: matrix-org/matrix-spec-proposals#244
Impl: matrix-org/synapse#453