Add test to ensure push/notifications work after room purge #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2023
erikjohnston
force-pushed
the
erikj/check_push_works_after_purge
branch
from
311c9c2
to
5f99718
Compare
erikjohnston
changed the title
clokep
reviewed
Jul 26, 2023
clokep
reviewed
Jul 26, 2023
Comment on lines
+574
to
+576
| # We expect notification count to be 2, as we'll still see two events: | ||
| # the first being $last_event_id and the second the "new message" | ||
| assert_eq( $room->{unread_notifications}{"notification_count"}, 2 ); |
There was a problem hiding this comment.
So do we expect a purge to force re-calculation of notification counts?
There was a problem hiding this comment.
Hmm, good question. I guess what I really want to test is that the notification count increases. Though given this is a Synapse only test I'm not hugely bothered if we test Synapse specific stuff here.
There was a problem hiding this comment.
I guess that makes sense. I think if you still have a event push summary on a purged event then it will increase properly? Not 100% sure on that though.
clokep
reviewed
Jul 26, 2023
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
clokep
approved these changes
Jul 28, 2023
|
Looks like a test might have flaked though? |
Ugh, yes. I'm failing to track that down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f. matrix-org/synapse#13476 (comment)