Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lazy-loading test which was looking for the wrong thing #1374

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Feb 20, 2024

As the comment says, this test was looking for the wrong thing, and actually enforcing buggy behaviour.

As the comment says, this test was looking for the wrong thing, and actually
enforcing buggy behaviour.
@richvdh
Copy link
Member Author

richvdh commented Feb 20, 2024

Looks like sytest's CI is broken :(

@S7evinK
Copy link
Contributor

S7evinK commented Feb 20, 2024

Looks like it is still trying to download the archive from the matrix-org/synapse repository:

(wget -O - "https://github.com/matrix-org/synapse/archive/$BRANCH_NAME.tar.gz" \

@richvdh richvdh merged commit 464864e into develop Apr 3, 2024
8 of 9 checks passed
@richvdh richvdh deleted the rav/fix_lazy_loading_test branch April 3, 2024 13:32
richvdh added a commit to element-hq/synapse that referenced this pull request Apr 4, 2024
Unfortunately, the optimisation we applied here for non-gappy syncs is
not actually valid.

Fixes #16941.

~~Based on #16930
Requires matrix-org/sytest#1374.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants