Test for SYN-589, that old left rooms don't get sent down new links #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -121,6 +121,69 @@ | |||
| }; | |||
|
|
|||
|
|
|||
| test "Oldly left rooms don't appear in the leave section of sync", | |||
|
I think that should be everything now |
| })->then( sub { | ||
| my ( $body ) = @_; | ||
|
|
||
| $next = $body->{next_batch}; |
There was a problem hiding this comment.
Do you need to assert that you definitely did see the newly-left room here, or is that checked already in another test?
There was a problem hiding this comment.
Its tested elsewhere.
I'm not sure how much I want to be complicating tests testing things that are tested elsewhere. I can do either.
There was a problem hiding this comment.
If it's tested elsewhere then no need to add it here, indeed.
|
LGTM |
erikjohnston
added a commit
that referenced
this pull request
Jan 13, 2016
Test for SYN-589, that old left rooms don't get sent down new links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.