Tests for peeking into rooms #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on matrix-org/synapse#510 |
| requires => [ anonymous_user_fixture(), local_user_fixture() ], | ||
| foreach my $i ( | ||
| ["Anonymous", sub { anonymous_user_fixture() }], | ||
| ["Real", sub { local_user_fixture() }] |
There was a problem hiding this comment.
Wants spaces inside [ ... ]
|
A cautious LGTM, as I haven't looked in too much detail at the logic of the tests; expecting they're just reïndented from the original ones outside the |
This duplicates all tests which should work for both anonymous users and real users peeking, so that both cases are actually tested. It also deletes the tests for /sync, because that isn't intended to be supported.
illicitonion
force-pushed
the
daniel/nonguestpeeking
branch
from
8af2b3f
to
231f1d4
Compare
illicitonion
added a commit
that referenced
this pull request
Jan 20, 2016
Tests for peeking into rooms This duplicates all tests which should work for both anonymous users and real users peeking, so that both cases are actually tested. It also deletes the tests for /sync, because that isn't intended to be supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This duplicates all tests which should work for both anonymous users and
real users peeking, so that both cases are actually tested.
It also deletes the tests for /sync, because that isn't intended to be supported.