Improve tests for history visibility #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
De-conflate the anonymous^Wguest access and world_readable tests; move the history visibility tests together into 30history-visibility.pl and extend them to cover world_readable. Put the tests for guest_access in 13guestaccess.pl.
richvdh
force-pushed
the
rav/guest_access_after_room_join
branch
from
ac6e5a1
to
c5c2104
Compare
| matrix_join_room( $guest_user, $room_id ) | ||
| })->then( sub { | ||
| matrix_send_room_text_message( $guest_user, $room_id, body => "sup" ); | ||
| })->then(sub { |
|
@leonerd: PTAL |
|
Now with a few other minor bits of syntax/whitespace neatening. LGTM |
|
thanks for the cleanups. |
richvdh
added a commit
that referenced
this pull request
Feb 25, 2016
Improve tests for history visibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests the functionality modifications in matrix-org/synapse#587.
De-conflate the
anonymousguest access and world_readable tests; move thehistory visibility tests together into 30history-visibility.pl and extend them
to cover world_readable. Put the tests for guest_access in 13guestaccess.pl.