Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial room summary tests #470

Merged
merged 11 commits into from
Aug 16, 2018
Merged

initial room summary tests #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4424280
initial room summary tests
ara4n Jul 23, 2018
d0ad3cb
namespace the summary fields correctly
ara4n Jul 23, 2018
c9d81e1
the user is never a hero :(
ara4n Jul 24, 2018
f0345c2
spell heroes correctly
ara4n Jul 24, 2018
63766fa
Merge branch 'matthew/members_at' into matthew/room_summary
ara4n Jul 27, 2018
698751b
Merge branch 'develop' into matthew/room_summary
ara4n Aug 12, 2018
057ae01
update tests to match invited_member_count behaviour
ara4n Aug 12, 2018
9173ca6
Merge branch 'matthew/members_at' into matthew/room_summary
ara4n Aug 12, 2018
428cde7
Merge branch 'matthew/members_at' into matthew/room_summary
ara4n Aug 15, 2018
9dd2686
use matrix_join_room_synced in the right places
ara4n Aug 15, 2018
79b6132
put an explicit name on the room for the LL tests to stop heroes gett…
ara4n Aug 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions tests/31sync/15lazy-members.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,11 @@
matrix_create_room_synced( $alice );
})->then( sub {
( $room_id ) = @_;
matrix_put_room_state( $alice, $room_id,
type => "m.room.name",
content => { name => "A room name" },
);
})->then( sub {
matrix_join_room( $bob, $room_id );
})->then( sub {
matrix_join_room( $charlie, $room_id );
Expand Down Expand Up @@ -136,6 +141,11 @@
matrix_create_room_synced( $alice );
})->then( sub {
( $room_id ) = @_;
matrix_put_room_state( $alice, $room_id,
type => "m.room.name",
content => { name => "A room name" },
);
})->then( sub {
matrix_join_room( $bob, $room_id );
})->then( sub {
matrix_join_room( $charlie, $room_id );
Expand Down Expand Up @@ -200,6 +210,11 @@
matrix_create_room_synced( $alice );
})->then( sub {
( $room_id ) = @_;
matrix_put_room_state( $alice, $room_id,
type => "m.room.name",
content => { name => "A room name" },
);
})->then( sub {
matrix_join_room( $bob, $room_id );
})->then( sub {
matrix_join_room( $charlie, $room_id );
Expand Down Expand Up @@ -279,6 +294,11 @@
matrix_create_room_synced( $alice );
})->then( sub {
( $room_id ) = @_;
matrix_put_room_state( $alice, $room_id,
type => "m.room.name",
content => { name => "A room name" },
);
})->then( sub {
matrix_join_room( $bob, $room_id );
})->then( sub {
matrix_join_room( $charlie, $room_id );
Expand Down Expand Up @@ -358,6 +378,11 @@
matrix_create_room_synced( $alice );
})->then( sub {
( $room_id ) = @_;
matrix_put_room_state( $alice, $room_id,
type => "m.room.name",
content => { name => "A room name" },
);
})->then( sub {
matrix_join_room( $bob, $room_id );
})->then( sub {
matrix_join_room( $charlie, $room_id );
Expand Down
140 changes: 140 additions & 0 deletions tests/31sync/16room-summary.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,140 @@
use Future::Utils qw( repeat );

test "Unnamed room comes with a name summary",
requires => [ local_user_fixtures( 3 ),
qw( can_sync ) ],

check => sub {
my ( $alice, $bob, $charlie ) = @_;

my ( $filter_id, $room_id );

matrix_create_filter( $alice, {
room => {
state => {
lazy_load_members => JSON::true
},
}
} )->then( sub {
( $filter_id ) = @_;

matrix_create_room_synced( $alice );
})->then( sub {
( $room_id ) = @_;
matrix_join_room_synced( $bob, $room_id );
})->then( sub {
matrix_join_room( $charlie, $room_id );
})->then( sub {
matrix_sync( $alice, filter => $filter_id );
})->then( sub {
my ( $body ) = @_;
log_if_fail ( "sync response:", $body->{rooms}{join}{$room_id} );
my $summary = $body->{rooms}{join}{$room_id}{summary};
assert_deeply_eq( $summary, {
'm.joined_member_count' => 3,
'm.invited_member_count' => 0,
'm.heroes' => [
$bob->user_id,
$charlie->user_id,
]
});
Future->done(1);
});
};

test "Named room comes with just joined member count summary",
requires => [ local_user_fixtures( 3 ),
qw( can_sync ) ],

check => sub {
my ( $alice, $bob, $charlie ) = @_;

my ( $filter_id, $room_id );

matrix_create_filter( $alice, {
room => {
state => {
lazy_load_members => JSON::true
},
}
} )->then( sub {
( $filter_id ) = @_;

matrix_create_room_synced( $alice );
})->then( sub {
( $room_id ) = @_;
matrix_put_room_state( $alice, $room_id,
type => "m.room.name",
content => { name => "A room name" },
);
})->then( sub {
matrix_join_room_synced( $bob, $room_id );
})->then( sub {
matrix_join_room( $charlie, $room_id );
})->then( sub {
matrix_sync( $alice, filter => $filter_id );
})->then( sub {
my ( $body ) = @_;
log_if_fail ( "sync response:", $body->{rooms}{join}{$room_id} );
my $summary = $body->{rooms}{join}{$room_id}{summary};
assert_deeply_eq($summary, {
'm.joined_member_count' => 3,
'm.invited_member_count' => 0,
});
Future->done(1);
});
};


test "Room summary only has 5 heroes",
requires => [ local_user_fixtures( 6 ),
qw( can_sync ) ],

check => sub {
my ( $alice, @users ) = @_;

my ( $filter_id, $room_id );

matrix_create_filter( $alice, {
room => {
state => {
lazy_load_members => JSON::true
},
}
} )->then( sub {
( $filter_id ) = @_;

matrix_create_room_synced( $alice );
})->then( sub {
( $room_id ) = @_;
repeat( sub {
matrix_join_room_synced( $_[0], $room_id );
}, foreach => [ @users ])
})->then( sub {
matrix_sync( $alice, filter => $filter_id );
})->then( sub {
my ( $body ) = @_;
log_if_fail ( "sync response:", $body->{rooms}{join}{$room_id} );
my $summary = $body->{rooms}{join}{$room_id}{summary};
my $expected_heroes = [
(sort(
$users[0]->user_id,
$users[1]->user_id,
$users[2]->user_id,
$users[3]->user_id,
$users[4]->user_id,
))[0..4]
];
log_if_fail( "expected_heroes:", $expected_heroes );
assert_deeply_eq($summary, {
'm.joined_member_count' => 6,
'm.invited_member_count' => 0,
'm.heroes' => $expected_heroes,
});
Future->done(1);
});
};

# TODO: test that parted users don't feature in room summaries, unless everyone has left
# TODO: check we receive room state for unknown hero mxids
# TODO: check that room summary changes whenever membership changes