Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that fetching device correctly resyncs #791

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston requested a review from a team January 28, 2020 17:42
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems generally plausible but could benefit from a little tidying?

tests/50federation/40devicelists.pl Outdated Show resolved Hide resolved
tests/50federation/40devicelists.pl Show resolved Hide resolved
tests/50federation/40devicelists.pl Outdated Show resolved Hide resolved
tests/50federation/40devicelists.pl Outdated Show resolved Hide resolved
tests/50federation/40devicelists.pl Outdated Show resolved Hide resolved
@erikjohnston
Copy link
Member Author

Ok, I've fixed it up a bit (rather than just copying and pasting other tests....)

@erikjohnston erikjohnston requested a review from a team January 29, 2020 10:10
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of nits of various levels of pedantry. lgtm.

tests/50federation/40devicelists.pl Outdated Show resolved Hide resolved
tests/50federation/40devicelists.pl Show resolved Hide resolved
tests/50federation/40devicelists.pl Outdated Show resolved Hide resolved
tests/50federation/40devicelists.pl Outdated Show resolved Hide resolved
tests/50federation/40devicelists.pl Outdated Show resolved Hide resolved
tests/50federation/40devicelists.pl Outdated Show resolved Hide resolved
tests/50federation/40devicelists.pl Outdated Show resolved Hide resolved
Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@erikjohnston erikjohnston merged commit 1d29387 into develop Jan 29, 2020
anoadragon453 added a commit that referenced this pull request Mar 23, 2020
…ease-v1.10.x

* origin/release-v1.10.0:
  remove checks on m.room.aliases (#801)
  Remove test which uses unspecced /events?dir=b (#794)
  Add some tests to check for adding/removing aliases (#792)
  Add test for ensuring power levels are correctly handled during upgrade (#777)
  Test that fetching device correctly resyncs (#791)
  Add support for experimental MSC2260 room version (#790)
  Fix power levels being sent as strings (#789)
  Don't respond with 503 as server will be marked as down. (#788)
  Test Synapse with MAU limits enabled. (#782)
  Fix docker/push.sh and make it echo commands
  Change postgres in docker image to use C collation/ctype. (#783)
  Add a passing test for recovery from gappy device list updates (#761)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants