-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for SSO + user interactive authentication. #845
Conversation
Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
9480cf3
to
cb5991e
Compare
Looks like rebasing this got the other test passing. 👍 This is ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
# A convenience function which wraps await_http_request. It returns a successful | ||
# CAS response when queried for a particular path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it'd be nice to document what the params
can be, but 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some.
…rite_whitelist_annotation * 'develop' of github.com:matrix-org/sytest: (42 commits) Fix OFFLINE support for the sytest-synapse docker image (#858) Add support for running worker mode against redis (#857) route GET account_data requests to client_reader (#855) Test that users receive updates for their own devices (#854) Add tests for SSO + user interactive authentication. (#845) Modify login tests to be spec compliant Make message history pagination test less flaky (#851) Small comment fixes for consistency (#808) Change room_fixture to run matrix_create_room_synced by default (#848) Update dendrite docs with new whitelist/blacklist info (#849) Add test for querying remote public rooms list with local server_name (#847) Add more logging to "Guest user can set display names" (#846) Add test for updating room aliases on upgraded room join (#844) Add tests to ensure that the operation cannot be modified during interactive auth. (#830) fix the CAS login test (#829) Update NOT_FOUND error to BAD_ALIAS error to be spec compliant. (#837) Missing bits Use r0 instead of 'unstable' for joined_members|rooms Add test to optionally keep other sessions when modifying a user's password. (#832) Remove tests that call query_auth endpoint. (#827) ...
…into dinsic * 'release-v1.13.0' of https://github.com/matrix-org/sytest: (23 commits) Dendrite: Show sytest compliance report after sytest runs (#864) Provide some examples of running sytest with worker mode synapse (#862) Fix build, don't build into source directory Maybe this time Better Just build the monolith server when testing Test for sending to_device messages to multiple recipients at once (#856) Mention required debian and cpan dependencies (#859) Add whitelist information to dendrite buildkite annotation (#803) Fix OFFLINE support for the sytest-synapse docker image (#858) Add support for running worker mode against redis (#857) Add tests for SSO + user interactive authentication. (#845) Modify login tests to be spec compliant Make message history pagination test less flaky (#851) Small comment fixes for consistency (#808) Change room_fixture to run matrix_create_room_synced by default (#848) Update dendrite docs with new whitelist/blacklist info (#849) Add test for querying remote public rooms list with local server_name (#847) Add more logging to "Guest user can set display names" (#846) Add test for updating room aliases on upgraded room join (#844) ...
This adds tests for using SSO in the user interactive authentication flow. It requires matrix-org/synapse#7186.