-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the usage of git-trailers for changelog messages #165
Conversation
Looks great. |
8f9d022
to
504ddfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
504ddfe
to
bcf87a0
Compare
@dkasak do you want to take a look at this or should I merge? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
=======================================
Coverage 90.55% 90.55%
=======================================
Files 34 34
Lines 1906 1906
=======================================
Hits 1726 1726
Misses 180 180 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🐑 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Left some suggested rephrasings.
6f41ca2
to
baf9cc9
Compare
This PR modifies the way
git-cliff
parses commits and produces changelog entries, please take a look at the updatedCONTRIBUTING.md
file for more info.In short, it allows us to write a commit like this:
To produce a changelog entry like this: