This repository has been archived by the owner on Sep 16, 2024. It is now read-only.
set default to official ChatGPT model from OpenAI #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should break something deliberately before merging this. Perhaps change the namespace of the package? |
|
maybe change the variable naming? |
Yeah that could do it. Something that requires user intervention. |
|
I like that idea! I'll implement the change shortly. |
|
I just noticed the env variable is optional and has a default, so a change of the variable will most likely not even be noticed by our users if they didn't change the model. |
|
Lets make it a required field with no default and adjust the name. |
|
I've also added an log entry if the new I think this is now ready for review 😃 |
bertybuttface
approved these changes
Mar 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of a "dangerous" change, as the OpenAI accounts of our users will be charged by simply updating the version to this one.
I'm not sure if we should adjust the readme any further in order to make this clear, so everyone knows the usage is no longer free (and most likely will never become free again at this point).
Also closes #120 and #119