Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support subscription in mo table size/rows. #20785

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

support subscription in mo table size/rows. #20785

wants to merge 7 commits into from
+319 −12

Conversation

gouhongshen
Copy link
Contributor

@gouhongshen gouhongshen commented Dec 17, 2024 •
edited
Loading

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue ##20739

What this PR does / why we need it:

mo table size/rows currently do not support subscription db and it never was.

@matrix-meow matrix-meow added the size/M Denotes a PR that changes [100,499] lines label Dec 17, 2024
@mergify mergify bot added kind/bug Something isn't working kind/enhancement labels Dec 17, 2024
@gouhongshen
Copy link
Contributor Author

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2024

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@gouhongshen gouhongshen force-pushed the support_subscription_in_mo_table_size_rows_to_main branch from 76500e0 to 585a74b Compare December 20, 2024 01:50
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2024

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heni02 heni02 heni02 approved these changes

@qingxinhome qingxinhome qingxinhome approved these changes

@daviszhen daviszhen daviszhen approved these changes

@m-schen m-schen m-schen approved these changes

@aunjgr aunjgr aunjgr approved these changes

@aressu1985 aressu1985 Awaiting requested review from aressu1985 aressu1985 is a code owner

Assignees
No one assigned
Labels
kind/bug Something isn't working kind/enhancement size/M Denotes a PR that changes [100,499] lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gouhongshen @aunjgr @m-schen @daviszhen @qingxinhome @heni02 @matrix-meow