Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the preCommitWrite in the commit routine. #20819

Merged
merged 5 commits into from
Dec 23, 2024
Merged

remove the preCommitWrite in the commit routine. #20819

merged 5 commits into from
Dec 23, 2024

Conversation

gouhongshen
Copy link
Contributor

@gouhongshen gouhongshen commented Dec 18, 2024 •
edited
Loading

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue ##20558

What this PR does / why we need it:

  1. pre commit write is designed for 2pc, current TN is running in the 1PC mode.

@matrix-meow matrix-meow added the size/M Denotes a PR that changes [100,499] lines label Dec 18, 2024
@gouhongshen gouhongshen requested a review from w-zr December 18, 2024 10:09
@gouhongshen gouhongshen force-pushed the remove_preCommitWrite branch from 955b4df to eaa58d2 Compare December 18, 2024 10:21
@mergify mergify bot merged commit ba1b490 into matrixorigin:main Dec 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviszhen daviszhen daviszhen approved these changes

@XuPeng-SH XuPeng-SH XuPeng-SH approved these changes

@w-zr w-zr w-zr approved these changes

@zhangxu19830126 zhangxu19830126 zhangxu19830126 approved these changes

@reusee reusee reusee approved these changes

Assignees
No one assigned
Labels
kind/enhancement size/M Denotes a PR that changes [100,499] lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gouhongshen @reusee @zhangxu19830126 @w-zr @XuPeng-SH @daviszhen @matrix-meow