Skip to content
This repository has been archived by the owner on Mar 19, 2022. It is now read-only.

no way of not including chef-solo-search #296

Closed
michaelglass opened this issue Oct 11, 2013 · 5 comments
Closed

no way of not including chef-solo-search #296

michaelglass opened this issue Oct 11, 2013 · 5 comments
Milestone

Comments

@michaelglass
Copy link
Contributor

I've patched chef-solo-search to support encrypted data bags.

When using knife-solo 0.2.0, I included my fork in my Cheffile.
When I upgraded, knife-solo 0.3.0 installed chef-solo-search v.4 and now my patches don't work.

Can we have a flag to disable auto-inclusion of chef-solo-search and/or to include a specific ref?

@matschaffer
Copy link
Owner

Ouch, that's a shame it hasn't been pulled in. Do you think be override
should maybe something in knife.rb or would a cli option do the trick?

On Thursday, October 10, 2013, Michael Glass wrote:

I've patched chef-solo-search to support encrypted data bagshttps://github.com/edelight/chef-solo-search/pull/38
.

When using knife-solo 0.2.0, I included my fork in my Cheffile.
When I upgraded, knife-solo 0.3.0 installed chef-solo-search v.4 and now
my patches don't work.

Can we have a flag to disable auto-inclusion of chef-solo-search and/or to
include a specific ref?


Reply to this email directly or view it on GitHubhttps://github.com//issues/296
.

-Mat

about.me/matschaffer

@michaelglass
Copy link
Contributor Author

Either way!

On Thursday, October 10, 2013, Mat Schaffer wrote:

Ouch, that's a shame it hasn't been pulled in. Do you think be override
should maybe something in knife.rb or would a cli option do the trick?

On Thursday, October 10, 2013, Michael Glass wrote:

I've patched chef-solo-search to support encrypted data bags<
https://github.com/edelight/chef-solo-search/pull/38>
.

When using knife-solo 0.2.0, I included my fork in my Cheffile.
When I upgraded, knife-solo 0.3.0 installed chef-solo-search v.4 and now
my patches don't work.

Can we have a flag to disable auto-inclusion of chef-solo-search and/or
to
include a specific ref?


Reply to this email directly or view it on GitHub<
https://github.com/matschaffer/knife-solo/issues/296>
.

-Mat

about.me/matschaffer


Reply to this email directly or view it on GitHubhttps://github.com//issues/296#issuecomment-26118039
.

Please excuse any typos. I'm all thumbs. (Sent from mobile)

michael_glass
@michaelglass
646-229-4050

@tmatilai
Copy link
Collaborator

Have you tested including the wanted chef-solo-search version to your own kitchen (with Berkshelf or Librarian-Chef if you prefer)? The bundled version should have lower precedence in cookbook_path. If not, it should be fixed.

@michaelglass
Copy link
Contributor Author

Really like that alternative. Include patched search first not last. I'll
submit a patch

On Friday, October 11, 2013, Teemu Matilainen wrote:

Have you tested including the wanted chef-solo-search version to your own
kitchen (with Berkshelf or Librarian-Chef if you prefer)? The bundled
version should have lower precedence in cookbook_path. If not, it should
be fixed.


Reply to this email directly or view it on GitHubhttps://github.com//issues/296#issuecomment-26140593
.

Please excuse any typos. I'm all thumbs. (Sent from mobile)

michael_glass
@michaelglass
646-229-4050

@matschaffer
Copy link
Owner

👍 to that. Looking forward to the patch!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants