Editing datascript for Olmsted#17, Olmsted#11, scons for Olmsted#13 #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 21, 2018 17:42
|
Latest commit adds potential fix for matsengrp/olmsted#13 |
eharkins
changed the title
metasoarous
reviewed
Sep 21, 2018
metasoarous
reviewed
Sep 21, 2018
metasoarous
reviewed
Sep 22, 2018
bin/build_olmsted_data.py
Outdated
| records = [] | ||
| leaves_counter = 1 | ||
| for n in tree.traverse('postorder'): | ||
| n.label = n.id = n.name | ||
| n.type = "node" | ||
| n.nt_seq = nt_seqs_dict[n.name] |
There was a problem hiding this comment.
@eharkins Mmm... here too. Please convert all tabs to spaces if that's what's going on.
metasoarous
reviewed
Sep 24, 2018
eharkins
changed the title
eharkins
changed the title
metasoarous
approved these changes
Sep 25, 2018
site_scons/software_versions.py
Outdated
| 'tripl': tripl_version, | ||
| #'nestly': lambda: nestly.__version__, |
There was a problem hiding this comment.
This may seem like minutia, but can you please comment in this style in python (and in js as well actually)? There's a nice vim plugin for letting you comment things out like this: https://github.com/scrooloose/nerdcommenter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matsengrp/olmsted#17
Not sure why the first two commits are supposedly different from the PR you already merged, the third commit is 0 changes, the last one is why I am making this PR