Remove temporary file after resizing it #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #55 for discussion of future maintenance of this project. |
matteotrubini
requested review from
matt-pawley,
matteotrubini,
chocolata and
rejuvenatedigital
|
Just tested this out, this works like a charm! Temporary files are deleted as they should and it has a big impact on server space. How do we proceed? |
|
@maartenmachiels please remember to merge PR on develop branch as agreed with @toughdeveloper See #55 (comment) |
|
Hi Matteo, I'm sorry for this. My mistake. I've reverted the changes. Could you kindly merge ea790a3 into develop? |
|
Already done (manually) via 3a840fc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45