General Improvements and Bug Fixes #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecation warnings were coming up warning about how boolean values where going to be typecasted incorrectly. This will type cast the boolean fields as true if they have anything and false if they don't.
Removed warnings from the spec helper and defaulting to sqlite3 database for testing as it has the lowest impact to get testing going.
Including active record because it breaks if you require this gem outside of a rails environment
Later versions like sr27 have changed their format and need to refrence sr27asc.zip now instead of jsut src27. This also attempts to follow redirects as it appears the path has been changing where the data store was orignally saved to.
1 similar comment
|
This is awesome. Thanks so much for doing this @benfalk. I haven't had any time to look at this project for a while. I'll try to look into this PR as soon as possible. Maybe we can just drop JRuby support if it's causing problems. |
|
Cool, sounds like a good idea. The current active record doesn't appear to support jruby 😞 . I have a couple more changes I'll try and get into master yet, but nothing all that amazing. Just removing some warnings and defaulting to sr27 👍 |
mattbeedle
added a commit
that referenced
this pull request
Jun 21, 2015
General Improvements and Bug Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation warnings were coming up warning about how boolean values
where going to be typecasted incorrectly. This will type cast the
boolean fields as true if they have anything and false if they don't.
Removed warnings from the spec helper and defaulting to sqlite3 database
for testing as it has the lowest impact to get testing going.
Including active record because it breaks if you require this gem
outside of a rails environment
Later versions like sr27 have changed their format and need to
refrence sr27asc.zip now instead of jsut src27. This also attempts
to follow redirects as it appears the path has been changing where
the data store was orignally saved to.