Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DynamoDB permissions #163

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Update DynamoDB permissions #163

merged 1 commit into from
Sep 20, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Sep 20, 2021

  • List/Remove tags
  • Manage backups

Attempts to revive #98

I'm working on a boto3 migration (I struggled to follow ansible-collections/community.aws#65 and it's been somewhat mangled in the migration from ansible/ansible to ansible-collections/community.aws so I'm starting with a simple migration)

@tremble
Copy link
Contributor Author

tremble commented Sep 20, 2021

Tests available at ansible-collections/community.aws#725 that I haven't broken anything, but I wanted to get the permissions lined up while I work locally on dynamodb.

Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no DynamoDb terminator class today; the existing policies here are to support the use of dynamo in DbTerminator. We'll need a new terminator class that ignores tables named like ansible_core_ci_resources_dev and ansible_core_ci_resources_prod.

@mattclay Any other concerns/considerations you'd have for adding terminator coverage for DynamoDb?

@tremble
Copy link
Contributor Author

tremble commented Sep 20, 2021

There's no DynamoDb terminator class today; the existing policies here are to support the use of dynamo in DbTerminator. We'll need a new terminator class that ignores tables named like ansible_core_ci_resources_dev and ansible_core_ci_resources_prod.

https://github.com/mattclay/aws-terminator/blob/master/aws/terminator/application_services.py#L328

@jillr
Copy link
Collaborator

jillr commented Sep 20, 2021

Never mind me, I failed at grep - the terminator class totally exists.

List/Remove tags
Manage backups
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@jillr jillr merged commit e6e4863 into mattclay:master Sep 20, 2021
@tremble tremble deleted the dynamodb branch February 10, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants