Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger component syntax highlighting #98

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

jackTabsCode
Copy link
Contributor

@jackTabsCode jackTabsCode commented Aug 9, 2024

SCR-20240808-rmdg

Some code cleanup, and conversion of string concatenation to template literals was done in this PR as well. This affects hover inspect as well, but does not affect the "loop parameter state views"

@jackTabsCode jackTabsCode requested a review from a team August 9, 2024 03:13
Copy link
Member

@Ukendio Ukendio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax highlighting looks really good. I am happy with the selected colours.

Can you show how it looks like when there are dots? I see in the code theres a special case that displays , .. and I want to see how that looks, because I suspect , ... would look better.

lib/debugger/formatTable.luau Show resolved Hide resolved
lib/debugger/formatTable.luau Show resolved Hide resolved
@jackTabsCode
Copy link
Contributor Author

The syntax highlighting looks really good. I am happy with the selected colours.

Can you show how it looks like when there are dots? I see in the code theres a special case that displays , .. and I want to see how that looks, because I suspect , ... would look better.

It looks the same as before with the dots, the 2 dots is existing behavior

@jackTabsCode jackTabsCode requested a review from Ukendio August 9, 2024 16:13
@jackTabsCode jackTabsCode merged commit 5510f86 into main Aug 9, 2024
6 checks passed
@jackTabsCode jackTabsCode deleted the components-syntax-highlighting branch August 9, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants