feat: Add support for vm.getCode in Zk context #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jrigada
changed the title
Jrigada
changed the title
…matter-labs/foundry-zksync into jrigada-vm-getCode-for-zksolc-contracts
Karrq
previously approved these changes
Oct 16, 2024
nbaztec
reviewed
Oct 17, 2024
nbaztec
reviewed
Oct 17, 2024
Karrq
approved these changes
Oct 18, 2024
|
@Jrigada can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The vm.getCode cheatcode was not supported when executing it with the
--zksyncflag because we did not have access to the zk artifacts. Now that we do we were getting multiple artifacts for a same contract.Solution
Whenever we need access to the known_contracts we have access to dual_compiled_contract so now we included the zk and non-zk paths in the struct so we can query the type (Zk, EVM) of contract given an artifact_id. With that we can filter and grab the correct contract depending which context we are in.