This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

Fix naive range checks in bigint_new #45

Open

tim-becker wants to merge 1 commit into matter-labs:dev from tim-becker:fix_naive_range_checks

tim-becker commented Mar 12, 2023 •

edited

Loading

We noticed a few bugs with the naive strategy for range checks:

The code assumed the wrong bit order fromBitIterator
In the fast case (num_bits < 4), the linear combination check wasn't actually being enforced
In the other case, d_next_coeff was being updated incorrectly.


          Fix naive range constraint in bigint_new

90e7939

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet